You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "xieshouyu (via GitHub)" <gi...@apache.org> on 2024/01/23 03:15:35 UTC
[PR] fix just consumers unregister serviceInstance [dubbo]
xieshouyu opened a new pull request, #13685:
URL: https://github.com/apache/dubbo/pull/13685
## What is the purpose of the change
1、fix just consumers unregister serviceInstance
## Brief changelog
1、set ServiceInstanceHostPortCustomizer Prioritized
2、add ServiceInstanceConsumerHostPortCustomizer fix just consumers unregister serviceInstance
## Verifying this change
Start the consumer application, and the host and port will be registered
<!-- Follow this checklist to help us incorporate your contribution quickly and easily: -->
## Checklist
- [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature.
- [ ] GitHub Actions works fine on your own branch.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix just consumers unregister serviceInstance [dubbo]
Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj commented on PR #13685:
URL: https://github.com/apache/dubbo/pull/13685#issuecomment-1923230070
Thanks for the contribution. Please explain in what scenario we would need this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix just consumers unregister serviceInstance [dubbo]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #13685:
URL: https://github.com/apache/dubbo/pull/13685#issuecomment-1918814872
## [Codecov](https://app.codecov.io/gh/apache/dubbo/pull/13685?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`2cf54f7`)](https://app.codecov.io/gh/apache/dubbo/commit/2cf54f7947596abbf92f907853a2df7cbfc8b7fb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 70.37% compared to head [(`a9cf89a`)](https://app.codecov.io/gh/apache/dubbo/pull/13685?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 70.33%.
> Report is 6 commits behind head on 3.2.
> :exclamation: Current head a9cf89a differs from pull request most recent head 95469d1. Consider uploading reports for the commit 95469d1 to get more accurate results
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 3.2 #13685 +/- ##
==========================================
- Coverage 70.37% 70.33% -0.05%
==========================================
Files 1606 1607 +1
Lines 70032 70062 +30
Branches 10104 10110 +6
==========================================
- Hits 49287 49280 -7
- Misses 16108 16145 +37
Partials 4637 4637
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo/pull/13685?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix just consumers unregister serviceInstance [dubbo]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #13685:
URL: https://github.com/apache/dubbo/pull/13685#issuecomment-1918808126
## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13685) **Quality Gate passed**
The SonarCloud Quality Gate passed, but some issues were introduced.
[2 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13685&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13685&resolved=false&inNewCodePeriod=true)
[74.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13685&metric=new_coverage&view=list)
[0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13685&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13685)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix just consumers unregister serviceInstance [dubbo]
Posted by "xieshouyu (via GitHub)" <gi...@apache.org>.
xieshouyu commented on PR #13685:
URL: https://github.com/apache/dubbo/pull/13685#issuecomment-1911683615
> Kindly incorporate additional contextual information to the purpose. Additionally, please include some test examples for comprehensive coverage.
Obtaining all consumers information of the provider interface can better manage internal interfaces. For example, providing a reference for an offline interface. I think this is the original advantage compared to the Spring Cloud system.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix just consumers unregister serviceInstance [dubbo]
Posted by "mytang0 (via GitHub)" <gi...@apache.org>.
mytang0 commented on PR #13685:
URL: https://github.com/apache/dubbo/pull/13685#issuecomment-1911465087
Kindly incorporate additional contextual information to the purpose. Additionally, please include some test examples for comprehensive coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix just consumers unregister serviceInstance [dubbo]
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on PR #13685:
URL: https://github.com/apache/dubbo/pull/13685#issuecomment-1911594027
@chickenlj PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix just consumers unregister serviceInstance [dubbo]
Posted by "xieshouyu (via GitHub)" <gi...@apache.org>.
xieshouyu commented on PR #13685:
URL: https://github.com/apache/dubbo/pull/13685#issuecomment-1911679094
> Kindly incorporate additional contextual information to the purpose. Additionally, please include some test examples for comprehensive coverage.
The original interface level can support querying all consumers corresponding to the provider interface. After forcing the application level, we are unable to obtain real-time subscription data for consumers. By registering the serviceInstance of the consumer, the admin can obtain the corresponding serviceInstance, thereby obtaining real-time subscription data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix just consumers unregister serviceInstance [dubbo]
Posted by "xieshouyu (via GitHub)" <gi...@apache.org>.
xieshouyu commented on PR #13685:
URL: https://github.com/apache/dubbo/pull/13685#issuecomment-1928767552
> Thanks for the contribution. Could you please explain in what scenario we would need this?
Prerequisite: dubbo. application. register mode=instance
For example, when we want to know in admin which business consumers a certain provider interface has. If only the consumer application is not registered, the admin will not be able to access all the data of business consumers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix just consumers unregister serviceInstance [dubbo]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #13685:
URL: https://github.com/apache/dubbo/pull/13685#issuecomment-1918862909
## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13685) **Quality Gate passed**
The SonarCloud Quality Gate passed, but some issues were introduced.
[2 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13685&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13685&resolved=false&inNewCodePeriod=true)
[73.6% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13685&metric=new_coverage&view=list)
[0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13685&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13685)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix just consumers unregister serviceInstance [dubbo]
Posted by "xieshouyu (via GitHub)" <gi...@apache.org>.
xieshouyu commented on PR #13685:
URL: https://github.com/apache/dubbo/pull/13685#issuecomment-1928735140
> Thanks for the contribution. Please explain in what scenario we would need this.
For example, when we want to know in admin which business consumers a certain provider interface has. If there is a lack of applications that only have consumers, the data obtained from business consumers will be incomplete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix just consumers unregister serviceInstance [dubbo]
Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj commented on PR #13685:
URL: https://github.com/apache/dubbo/pull/13685#issuecomment-1923225811
Thanks for the contribution. Could you please explain in what scenario we would need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix just consumers unregister serviceInstance [dubbo]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #13685:
URL: https://github.com/apache/dubbo/pull/13685#issuecomment-2007101194
## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13685) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13685&resolved=false&inNewCodePeriod=true)
 [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13685&metric=new_accepted_issues&view=list)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13685&resolved=false&inNewCodePeriod=true)
 [9.8% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13685&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13685&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13685)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix just consumers unregister serviceInstance [dubbo]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #13685:
URL: https://github.com/apache/dubbo/pull/13685#issuecomment-2005986817
## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13685) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13685&resolved=false&inNewCodePeriod=true)
 [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13685&metric=new_accepted_issues&view=list)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13685&resolved=false&inNewCodePeriod=true)
 [7.5% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13685&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13685&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13685)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org