You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/03/25 04:16:05 UTC
Review Request: Fixed MasterTest.ShutdownUnregisteredExecutor test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10113/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Description
-------
See summary.
This addresses bug MESOS-412.
https://issues.apache.org/jira/browse/MESOS-412
Diffs
-----
src/tests/master_tests.cpp 16f7637c144160448ca8f3eb50924be3a70d2c3d
Diff: https://reviews.apache.org/r/10113/diff/
Testing
-------
sudo GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="*ShutdownUnregisteredExecutor*" --verbose --gtest_repeat=-1 --gtest_break_on_failure
Thanks,
Vinod Kone
Re: Review Request: Fixed MasterTest.ShutdownUnregisteredExecutor test.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10113/#review18358
-----------------------------------------------------------
src/tests/master_tests.cpp
<https://reviews.apache.org/r/10113/#comment38560>
Can you experiment with smaller sleeps?
Is 10 milliseconds enough? If not, 100 should be enough?
I'd like to minimize sleep times in our tests.
- Ben Mahler
On March 25, 2013, 3:16 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10113/
> -----------------------------------------------------------
>
> (Updated March 25, 2013, 3:16 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> This addresses bug MESOS-412.
> https://issues.apache.org/jira/browse/MESOS-412
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 16f7637c144160448ca8f3eb50924be3a70d2c3d
>
> Diff: https://reviews.apache.org/r/10113/diff/
>
>
> Testing
> -------
>
> sudo GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="*ShutdownUnregisteredExecutor*" --verbose --gtest_repeat=-1 --gtest_break_on_failure
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fixed MasterTest.ShutdownUnregisteredExecutor test.
Posted by Vinod Kone <vi...@gmail.com>.
> On March 25, 2013, 10:12 p.m., Benjamin Hindman wrote:
> > src/tests/master_tests.cpp, line 929
> > <https://reviews.apache.org/r/10113/diff/2/?file=274386#file274386line929>
> >
> > I think we need os::sleep which takes a Duration and calls usleep under the covers!
Agreed. Filed https://issues.apache.org/jira/browse/MESOS-415 against me.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10113/#review18369
-----------------------------------------------------------
On March 25, 2013, 7:47 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10113/
> -----------------------------------------------------------
>
> (Updated March 25, 2013, 7:47 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> This addresses bug MESOS-412.
> https://issues.apache.org/jira/browse/MESOS-412
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 16f7637c144160448ca8f3eb50924be3a70d2c3d
>
> Diff: https://reviews.apache.org/r/10113/diff/
>
>
> Testing
> -------
>
> sudo GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="*ShutdownUnregisteredExecutor*" --verbose --gtest_repeat=-1 --gtest_break_on_failure
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fixed MasterTest.ShutdownUnregisteredExecutor test.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10113/#review18369
-----------------------------------------------------------
Ship it!
Ship It!
src/tests/master_tests.cpp
<https://reviews.apache.org/r/10113/#comment38574>
I think we need os::sleep which takes a Duration and calls usleep under the covers!
- Benjamin Hindman
On March 25, 2013, 7:47 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10113/
> -----------------------------------------------------------
>
> (Updated March 25, 2013, 7:47 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> This addresses bug MESOS-412.
> https://issues.apache.org/jira/browse/MESOS-412
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 16f7637c144160448ca8f3eb50924be3a70d2c3d
>
> Diff: https://reviews.apache.org/r/10113/diff/
>
>
> Testing
> -------
>
> sudo GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="*ShutdownUnregisteredExecutor*" --verbose --gtest_repeat=-1 --gtest_break_on_failure
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fixed MasterTest.ShutdownUnregisteredExecutor test.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10113/#review18376
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On March 25, 2013, 7:47 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10113/
> -----------------------------------------------------------
>
> (Updated March 25, 2013, 7:47 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> This addresses bug MESOS-412.
> https://issues.apache.org/jira/browse/MESOS-412
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 16f7637c144160448ca8f3eb50924be3a70d2c3d
>
> Diff: https://reviews.apache.org/r/10113/diff/
>
>
> Testing
> -------
>
> sudo GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="*ShutdownUnregisteredExecutor*" --verbose --gtest_repeat=-1 --gtest_break_on_failure
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fixed MasterTest.ShutdownUnregisteredExecutor test.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10113/
-----------------------------------------------------------
(Updated March 25, 2013, 7:47 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
benm's
Description
-------
See summary.
This addresses bug MESOS-412.
https://issues.apache.org/jira/browse/MESOS-412
Diffs (updated)
-----
src/tests/master_tests.cpp 16f7637c144160448ca8f3eb50924be3a70d2c3d
Diff: https://reviews.apache.org/r/10113/diff/
Testing
-------
sudo GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="*ShutdownUnregisteredExecutor*" --verbose --gtest_repeat=-1 --gtest_break_on_failure
Thanks,
Vinod Kone