You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/01/06 02:05:46 UTC

[GitHub] [skywalking] zifeihan commented on a change in pull request #6133: Fix mssql-plugin occur ClassCastException when call the method of return generate key

zifeihan commented on a change in pull request #6133:
URL: https://github.com/apache/skywalking/pull/6133#discussion_r552323233



##########
File path: apm-sniffer/apm-sdk-plugin/mssql-jdbc-plugin/src/main/resources/skywalking-plugin.def
##########
@@ -16,3 +16,5 @@
 
 mssql-jdbc=org.apache.skywalking.apm.plugin.mssql.jdbc.define.DriverInstrumentation
 mssql-jdbc=org.apache.skywalking.apm.plugin.mssql.jdbc.define.ConnectionInstrumentation
+mssql-jdbc=org.apache.skywalking.apm.plugin.mssql.jdbc.define.PreparedStatementInstrumentation
+mssql-jdbc=org.apache.skywalking.apm.plugin.mssql.jdbc.define.StatementInstrumentation

Review comment:
       In the previous packaging mode, statement was packaged by `org.apache.skywalking.apm.plugin.jdbc.JDBCStatementInterceptor`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org