You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Flavio Percoco <fl...@gmail.com> on 2015/08/17 22:24:09 UTC
Review Request 37552: NO-JIRA: Handle 2-digit and 3-digit version
numbers
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37552/
-----------------------------------------------------------
Review request for qpid and Kenneth Giusti.
Repository: qpid-proton-git
Description
-------
NO-JIRA: Handle 2-digit and 3-digit version numbers
Diffs
-----
proton-c/bindings/python/setuputils/bundle.py 13b88e09081fcea134f785053ea316501c7ffc18
Diff: https://reviews.apache.org/r/37552/diff/
Testing
-------
Thanks,
Flavio Percoco
Re: Review Request 37552: NO-JIRA: Handle 2-digit and 3-digit version
numbers
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37552/#review95711
-----------------------------------------------------------
Ship it!
Thanks - looks great.
- Kenneth Giusti
On Aug. 17, 2015, 9:52 p.m., Flavio Percoco wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37552/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2015, 9:52 p.m.)
>
>
> Review request for qpid and Kenneth Giusti.
>
>
> Repository: qpid-proton-git
>
>
> Description
> -------
>
> NO-JIRA: Handle 2-digit and 3-digit version numbers
>
>
> Diffs
> -----
>
> proton-c/bindings/python/setuputils/bundle.py 13b88e09081fcea134f785053ea316501c7ffc18
>
> Diff: https://reviews.apache.org/r/37552/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Flavio Percoco
>
>
Re: Review Request 37552: NO-JIRA: Handle 2-digit and 3-digit version
numbers
Posted by Flavio Percoco <fl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37552/
-----------------------------------------------------------
(Updated Aug. 17, 2015, 9:52 p.m.)
Review request for qpid and Kenneth Giusti.
Repository: qpid-proton-git
Description
-------
NO-JIRA: Handle 2-digit and 3-digit version numbers
Diffs (updated)
-----
proton-c/bindings/python/setuputils/bundle.py 13b88e09081fcea134f785053ea316501c7ffc18
Diff: https://reviews.apache.org/r/37552/diff/
Testing
-------
Thanks,
Flavio Percoco
Re: Review Request 37552: NO-JIRA: Handle 2-digit and 3-digit version
numbers
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37552/#review95631
-----------------------------------------------------------
proton-c/bindings/python/setuputils/bundle.py (line 39)
<https://reviews.apache.org/r/37552/#comment150740>
can you use the X if Y else Z syntax here instead?
Just personal preference (I hate having to look up operator precedence for every language I need to hack).
- Kenneth Giusti
On Aug. 17, 2015, 8:24 p.m., Flavio Percoco wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37552/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2015, 8:24 p.m.)
>
>
> Review request for qpid and Kenneth Giusti.
>
>
> Repository: qpid-proton-git
>
>
> Description
> -------
>
> NO-JIRA: Handle 2-digit and 3-digit version numbers
>
>
> Diffs
> -----
>
> proton-c/bindings/python/setuputils/bundle.py 13b88e09081fcea134f785053ea316501c7ffc18
>
> Diff: https://reviews.apache.org/r/37552/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Flavio Percoco
>
>