You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by "xubo245 (via GitHub)" <gi...@apache.org> on 2023/08/19 14:45:56 UTC

[GitHub] [carbondata] xubo245 opened a new pull request, #4330: [ISSUE-4329] optimize some code smells in presto module

xubo245 opened a new pull request, #4330:
URL: https://github.com/apache/carbondata/pull/4330

   static method shouldn't be called by object, it should be call by class
   
    ### Why is this PR needed?
    There are some code smells in presto module
   For example
   1.Didn't add @OverRide for override method
   2.magic number
   3.variable Should Use LowerCamelCase
    
    ### What changes were proposed in this PR?
   
       optimize some code smells in presto module
    ### Does this PR introduce any user interface change?
    - No
   
    ### Is any new testcase added?
    - No
   
       
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] chenliang613 commented on pull request #4330: [ISSUE-4329] optimize some code smells in presto module

Posted by "chenliang613 (via GitHub)" <gi...@apache.org>.
chenliang613 commented on PR #4330:
URL: https://github.com/apache/carbondata/pull/4330#issuecomment-1741989276

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [carbondata] chenliang613 merged pull request #4330: [ISSUE-4329] optimize some code smells in presto module

Posted by "chenliang613 (via GitHub)" <gi...@apache.org>.
chenliang613 merged PR #4330:
URL: https://github.com/apache/carbondata/pull/4330


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org