You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2022/10/25 20:30:20 UTC

[GitHub] [thrift] jeking3 commented on a diff in pull request #2719: THRIFT-5657: Use Swift 5.7 in all CI (github actions + travis)

jeking3 commented on code in PR #2719:
URL: https://github.com/apache/thrift/pull/2719#discussion_r1004936388


##########
.github/workflows/build.yml:
##########
@@ -275,6 +275,11 @@ jobs:
     steps:
       - uses: actions/checkout@v3
 
+      - name: Setup Swift
+        uses: swift-actions/setup-swift@v1.18.0
+        with:
+          swift-version: "5.7"

Review Comment:
   I would advise using the build containers over building an environment with GHA for every CI job (as it was, in the past).  Builds will take longer if you have to pull in every language like this, as opposed to downloading a one-time generated build container with everything in it.  With a build container anyone can use it to build the entire package locally and the local build is the same as the CI build.  With GHA scripted build environments like this, only GHA can run the build.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org