You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "nvazquez (via GitHub)" <gi...@apache.org> on 2023/02/15 01:16:21 UTC

[GitHub] [cloudstack] nvazquez opened a new pull request, #7230: UI: Fix keyboard options regression

nvazquez opened a new pull request, #7230:
URL: https://github.com/apache/cloudstack/pull/7230

   ### Description
   
   This PR fixes a UI regression on the keyboard options on the Deploy Instance wizard:
   
   ![image](https://user-images.githubusercontent.com/5295080/218899852-1c36f9f5-f445-4ad7-96dc-b55444cee485.png)
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   Deploy Instance wizard -> Verify new text options for keyboard
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7230: UI: Fix keyboard options regression

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7230:
URL: https://github.com/apache/cloudstack/pull/7230#issuecomment-1430653644

   UI build: :heavy_check_mark:
   Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7230 (QA-JID-46)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] stephankruggg commented on a diff in pull request #7230: UI: Fix keyboard options regression

Posted by "stephankruggg (via GitHub)" <gi...@apache.org>.
stephankruggg commented on code in PR #7230:
URL: https://github.com/apache/cloudstack/pull/7230#discussion_r1107251302


##########
ui/public/locales/nl_NL.json:
##########
@@ -1016,6 +1017,7 @@
 "label.sharedmountpoint": "SharedMountPoint",
 "label.shrinkok": "Verklein OK",
 "label.shutdown.provider": "Schakel provider uit",
+"label.simplified.chinese.keyboard": "versimpeld Chinees toetsenbord",

Review Comment:
   Sorry, did not know that. In that case, I agree. The intention of my suggestion was to standardize the first letter as capitalized, as in other files. :smiley: 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #7230: UI: Fix keyboard options regression

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7230:
URL: https://github.com/apache/cloudstack/pull/7230#issuecomment-1431510435

   This is not the first issue , maybe also not the last issue caused by #6326


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7230: UI: Fix keyboard options regression

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7230:
URL: https://github.com/apache/cloudstack/pull/7230#issuecomment-1430648931

   @nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] codecov[bot] commented on pull request #7230: UI: Fix keyboard options regression

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7230:
URL: https://github.com/apache/cloudstack/pull/7230#issuecomment-1430741962

   # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7230?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#7230](https://codecov.io/gh/apache/cloudstack/pull/7230?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (87f19c2) into [main](https://codecov.io/gh/apache/cloudstack/commit/597a8030b7c3235e59207041634206bead379c08?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (597a803) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff            @@
   ##               main    #7230   +/-   ##
   =========================================
     Coverage     12.67%   12.67%           
     Complexity     8639     8639           
   =========================================
     Files          2716     2716           
     Lines        256112   256112           
     Branches      39926    39926           
   =========================================
     Hits          32456    32456           
     Misses       219528   219528           
     Partials       4128     4128           
   ```
   
   
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] harikrishna-patnala commented on pull request #7230: UI: Fix keyboard options regression

Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on PR #7230:
URL: https://github.com/apache/cloudstack/pull/7230#issuecomment-1430825760

   verified LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7230: UI: Fix keyboard options regression

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7230:
URL: https://github.com/apache/cloudstack/pull/7230#issuecomment-1434536293

   @nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] stephankruggg commented on a diff in pull request #7230: UI: Fix keyboard options regression

Posted by "stephankruggg (via GitHub)" <gi...@apache.org>.
stephankruggg commented on code in PR #7230:
URL: https://github.com/apache/cloudstack/pull/7230#discussion_r1107165819


##########
ui/public/locales/pt_BR.json:
##########
@@ -874,6 +874,7 @@
 "label.isvolatile": "Vol\u00e1til",
 "label.items": "itens",
 "label.items.selected": "item(ns) selecionados",
+"label.japanese.keyboard": "Japanese keyboard",

Review Comment:
   ```suggestion
   "label.japanese.keyboard": "Teclado japon\u00eas",
   ```



##########
ui/public/locales/nl_NL.json:
##########
@@ -1016,6 +1017,7 @@
 "label.sharedmountpoint": "SharedMountPoint",
 "label.shrinkok": "Verklein OK",
 "label.shutdown.provider": "Schakel provider uit",
+"label.simplified.chinese.keyboard": "versimpeld Chinees toetsenbord",

Review Comment:
   ```suggestion
   "label.simplified.chinese.keyboard": "Versimpeld Chinees toetsenbord",
   ```



##########
ui/public/locales/pt_BR.json:
##########
@@ -1504,6 +1506,7 @@
 "label.ssh.port": "Porta SSH",
 "label.sshkeypair": "Novo par de chaves SSH",
 "label.sshkeypairs": "Par de chaves SSH",
+"label.standard.us.keyboard": "Standard (US) keyboard",

Review Comment:
   ```suggestion
   "label.standard.us.keyboard": "Teclado padr\u00e3o (EUA)",
   ```



##########
ui/public/locales/pt_BR.json:
##########
@@ -1631,6 +1634,7 @@
 "label.type.id": "Tipo do ID",
 "label.ucs": "UCS",
 "label.udp": "UDP",
+"label.uk.keyboard": "UK keyboard",

Review Comment:
   ```suggestion
   "label.uk.keyboard": "Teclado do Reino Unido",
   ```



##########
ui/public/locales/pt_BR.json:
##########
@@ -1471,6 +1472,7 @@
 "label.showing": "Exibindo",
 "label.shrinkok": "Encolhimento OK",
 "label.shutdown.provider": "Desabilitar provider",
+"label.simplified.chinese.keyboard": "Simplified Chinese keyboard",

Review Comment:
   ```suggestion
   "label.simplified.chinese.keyboard": "Teclado chin\u00eas simplificado",
   ```



##########
ui/public/locales/nl_NL.json:
##########
@@ -1042,6 +1044,7 @@
 "label.srx": "SRX",
 "label.ssh.key.pairs": "SSH sleutel paren",
 "label.sshkeypair": "nieuw SSH sleutelpaar",
+"label.standard.us.keyboard": "standaard (Amerikaans-US) toetsenbord",

Review Comment:
   ```suggestion
   "label.standard.us.keyboard": "Standaard (Amerikaans-US) toetsenbord",
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7230: UI: Fix keyboard options regression

Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #7230:
URL: https://github.com/apache/cloudstack/pull/7230#issuecomment-1434611278

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7230)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7230&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7230&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7230&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7230&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7230&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7230&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7230&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7230&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7230&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7230&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7230&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7230&resolved=false&types=CODE_SMELL)
   
   [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7230&metric=coverage&view=list) No Coverage information  
   [![No Duplication information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png 'No Duplication information')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7230&metric=duplicated_lines_density&view=list) No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7230: UI: Fix keyboard options regression

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7230:
URL: https://github.com/apache/cloudstack/pull/7230#issuecomment-1434543276

   UI build: :heavy_check_mark:
   Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7230 (QA-JID-48)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7230: UI: Fix keyboard options regression

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #7230:
URL: https://github.com/apache/cloudstack/pull/7230#discussion_r1107213421


##########
ui/public/locales/nl_NL.json:
##########
@@ -1042,6 +1044,7 @@
 "label.srx": "SRX",
 "label.ssh.key.pairs": "SSH sleutel paren",
 "label.sshkeypair": "nieuw SSH sleutelpaar",
+"label.standard.us.keyboard": "standaard (Amerikaans-US) toetsenbord",

Review Comment:
   nor this one



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7230: UI: Fix keyboard options regression

Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #7230:
URL: https://github.com/apache/cloudstack/pull/7230#issuecomment-1430692668

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7230)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7230&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7230&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7230&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7230&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7230&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7230&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7230&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7230&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7230&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7230&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7230&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7230&resolved=false&types=CODE_SMELL)
   
   [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7230&metric=coverage&view=list) No Coverage information  
   [![No Duplication information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png 'No Duplication information')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7230&metric=duplicated_lines_density&view=list) No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #7230: UI: Fix keyboard options regression

Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #7230:
URL: https://github.com/apache/cloudstack/pull/7230#issuecomment-1430889771

   Verified on QA server
   
   ![Screenshot from 2023-02-15 13-16-01](https://user-images.githubusercontent.com/153340/218964625-31bd07bb-4b82-4e5e-8cfc-99578985439b.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7230: UI: Fix keyboard options regression

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #7230:
URL: https://github.com/apache/cloudstack/pull/7230#discussion_r1107212129


##########
ui/public/locales/nl_NL.json:
##########
@@ -1016,6 +1017,7 @@
 "label.sharedmountpoint": "SharedMountPoint",
 "label.shrinkok": "Verklein OK",
 "label.shutdown.provider": "Schakel provider uit",
+"label.simplified.chinese.keyboard": "versimpeld Chinees toetsenbord",

Review Comment:
   It is not very dutch to capatilise common nounc and verbs, @stephankruggg . I would not apply this. It is considered shouting or self glorification.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #7230: UI: Fix keyboard options regression

Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #7230:
URL: https://github.com/apache/cloudstack/pull/7230#issuecomment-1430648214

   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #7230: UI: Fix keyboard options regression

Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #7230:
URL: https://github.com/apache/cloudstack/pull/7230#issuecomment-1434535755

   Thanks @stephankruggg I've applied your suggestions for portuguese
   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland merged pull request #7230: UI: Fix keyboard options regression

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #7230:
URL: https://github.com/apache/cloudstack/pull/7230


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org