You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Asura7969 (via GitHub)" <gi...@apache.org> on 2023/11/10 15:18:17 UTC
[PR] Improve documentation for calculate_prune_length method [arrow-datafusion]
Asura7969 opened a new pull request, #8125:
URL: https://github.com/apache/arrow-datafusion/pull/8125
## Which issue does this PR close?
N/A
## Rationale for this change
Improve documentation for calculate_prune_length method
## What changes are included in this PR?
N/A
## Are these changes tested?
doctests
## Are there any user-facing changes?
Just Docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve documentation for calculate_prune_length method in `SymmetricHashJoin` [arrow-datafusion]
Posted by "metesynnada (via GitHub)" <gi...@apache.org>.
metesynnada commented on code in PR #8125:
URL: https://github.com/apache/arrow-datafusion/pull/8125#discussion_r1390188593
##########
datafusion/physical-plan/src/joins/symmetric_hash_join.rs:
##########
@@ -952,27 +952,17 @@ impl OneSideHashJoiner {
Ok(())
}
- /// Prunes the internal buffer.
- ///
- /// Argument `probe_batch` is used to update the intervals of the sorted
- /// filter expressions. The updated build interval determines the new length
- /// of the build side. If there are rows to prune, they are removed from the
- /// internal buffer.
+ /// Calculate prune length.
Review Comment:
Removes the outdated comment, thanks for the contribution.
##########
datafusion/physical-plan/src/joins/symmetric_hash_join.rs:
##########
@@ -952,27 +952,17 @@ impl OneSideHashJoiner {
Ok(())
}
- /// Prunes the internal buffer.
- ///
- /// Argument `probe_batch` is used to update the intervals of the sorted
- /// filter expressions. The updated build interval determines the new length
- /// of the build side. If there are rows to prune, they are removed from the
- /// internal buffer.
+ /// Calculate prune length.
Review Comment:
Removes the outdated comment, thanks for the contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve documentation for calculate_prune_length method in `SymmetricHashJoin` [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #8125:
URL: https://github.com/apache/arrow-datafusion/pull/8125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org