[GitHub] [superset] ktmud commented on pull request #13434: fix(query): properly select adhoc metrics in orderby

[GitBox <gi...@apache.org>]

ktmud commented on pull request #13434:
URL: https://github.com/apache/superset/pull/13434#issuecomment-791604596


   Thanks for the headsup, @villebro !
   
   Another thing I noticed is that it's not always correct to assume "columns" with no "metrics" requires no aggregation. E.g. when table chart selects `groupby` with no metrics in aggregation mode, the output should be unique combination of the groups instead of raw records. This is mentioned as the second problem in #13228 .
   
   Therefore we can not really deprecate `groupby` in `QueryObject`. Or we will need to add at least an `is_aggregate` flag is `groupby` is to be cleaned up.
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org