[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10809: [multistage][bugfix] order by limit is capped at 10_000

["Jackie-Jiang (via GitHub)" <gi...@apache.org>]

Jackie-Jiang commented on code in PR #10809:
URL: https://github.com/apache/pinot/pull/10809#discussion_r1210629473


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/SortOperator.java:
##########
@@ -82,7 +86,7 @@ public SortOperator(OpChainExecutionContext context, MultiStageOperator upstream
     } else {
       // Use the opposite direction as specified by the collation directions since we need the PriorityQueue to decide
       // which elements to keep and which to remove based on the limits.
-      _priorityQueue = new PriorityQueue<>(_numRowsToKeep,
+      _priorityQueue = new PriorityQueue<>(defaultHolderCapacity,

Review Comment:
   Use min of the 2



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org