[jira] Commented: (OWB-132) atinject license header formatting breaks build

["Mark Struberg (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OWB-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746427#action_12746427 ] 

Mark Struberg commented on OWB-132:
-----------------------------------

one short comment:

Thanks for checking David!
We now took the ASL header I know from maven, openjpa and myfaces. Our old was the same from the wording, but I must have ripped up the formatting with some reformat in Eclipse *blush*

I only use /* instead of /** because I like to additionally comment the interfaces in the near future. But I don't like to simply copy it over from the JSR because of copyright issues.

We also added a separate LICENSE.txt and NOTICE.txt. Can you please check if the NOTICE is correct? I wrote all the code myself, so do we need to reference the JSR-330 EG in it?

rat:check now succeeds without any warning at least :)

> atinject license header formatting breaks build
> -----------------------------------------------
>
>                 Key: OWB-132
>                 URL: https://issues.apache.org/jira/browse/OWB-132
>             Project: OpenWebBeans
>          Issue Type: Bug
>            Reporter: David Blevins
>            Assignee: Gurkan Erdogdu
>             Fix For: M3
>
>         Attachments: OWB-132.txt
>
>
> Some files are missing the header and some have the header but with formatting that doesn't allow it to be recognized as the ASL 2.0 buy the tooling.   Build currently fails:
> [INFO] ------------------------------------------------------------------------
> [ERROR] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Too many unapproved licenses: 6
> [INFO] ------------------------------------------------------------------------
> [INFO] For more information, run Maven with the -e switch
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 12 seconds
> [INFO] Finished at: Fri Aug 21 18:52:13 PDT 2009
> [INFO] Final Memory: 41M/87M
> [INFO] ------------------------------------------------------------------------
> Attaching a patch.  Also added a the extra warning that Geronimo puts on all its spec source so people know not to edit them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.