You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/10/19 18:08:01 UTC
[PR] [SPARK-60349] Fix `StreamingQuery` creation to throw instead of trapping on non-UUID query ids from the server [spark-connect-swift]
dongjoon-hyun opened a new pull request, #600:
URL: https://github.com/apache/spark-connect-swift/pull/600
### What changes were proposed in this pull request?
Replace the `UUID(uuidString:)!` force unwraps on server-provided query ids with a throwing `StreamingQuery` initializer that throws `SparkConnectError.invalidArgument` for non-UUID `id`/`runId`. It is used in `DataStreamWriter.start()`, `StreamingQueryManager.active`, and `StreamingQueryManager.get(_:)`.
### Why are the changes needed?
A non-UUID `id` or `runId` from the server currently traps and crashes the application. All three call sites already `throws`, so a malformed response can surface as a catchable error instead.
### Does this PR introduce _any_ user-facing change?
Only for malformed server responses: an error is thrown instead of a crash.
### How was this patch tested?
Added `StreamingQueryTests.createFromQueryID`, which needs no server. Tests that need a live server were not run locally.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Sonnet 5.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-60349] Fix `StreamingQuery` creation to throw instead of trapping on non-UUID query ids from the server [spark-connect-swift]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #600: [SPARK-60349] Fix `StreamingQuery` creation to throw instead of trapping on non-UUID query ids from the server
URL: https://github.com/apache/spark-connect-swift/pull/600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-60349] Fix `StreamingQuery` creation to throw instead of trapping on non-UUID query ids from the server [spark-connect-swift]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #600:
URL: https://github.com/apache/spark-connect-swift/pull/600#issuecomment-6274979651
Thank you, @viirya !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-60349] Fix `StreamingQuery` creation to throw instead of trapping on non-UUID query ids from the server [spark-connect-swift]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #600:
URL: https://github.com/apache/spark-connect-swift/pull/600#issuecomment-6274989634
Merged to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org