You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/05/07 11:50:16 UTC

[GitHub] fmaximus commented on a change in pull request #2602: CLOUDSTACK-10365: Change the "getXXX" boolean-related method names to…

fmaximus commented on a change in pull request #2602: CLOUDSTACK-10365: Change the "getXXX" boolean-related method names to…
URL: https://github.com/apache/cloudstack/pull/2602#discussion_r186400148
 
 

 ##########
 File path: api/src/main/java/com/cloud/offering/ServiceOffering.java
 ##########
 @@ -76,7 +76,7 @@
     /**
      * @return Does this service plan offer HA?
      */
-    boolean getOfferHA();
+    boolean isOfferHA();
 
 Review comment:
   @DaanHoogland I would prefer to only have methods starting with either get or is.
   Any other method name in a VO would not be usable for filtering,
   according to the implementation of the VO MethodInterceptor

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services