Re: [PR] [SPARK-54014][CONNECT] Support max rows for SparkConnectStatement [spark]

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #52742:
URL: https://github.com/apache/spark/pull/52742#discussion_r2485680012


##########
sql/connect/client/jdbc/src/main/scala/org/apache/spark/sql/connect/client/jdbc/SparkConnectStatement.scala:
##########
@@ -61,7 +66,10 @@ class SparkConnectStatement(conn: SparkConnectConnection) extends Statement {
   override def executeUpdate(sql: String): Int = {
     checkOpen()
 
-    val df = conn.spark.sql(sql)
+    var df = conn.spark.sql(sql)
+    if (limitRow > 0) {
+      df = df.limit(limitRow)

Review Comment:
   has been rebased on SPARK-54108



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org