You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/05/15 16:19:03 UTC
Review Request 67136: Added a function to get rlimits.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67136/
-----------------------------------------------------------
Review request for mesos, Jie Yu and James Peach.
Repository: mesos
Description
-------
Added a function to get rlimits.
Diffs
-----
src/posix/rlimits.hpp 0cc4d8aa58e400c0509969acdb5bd30bf89146da
src/posix/rlimits.cpp 6446c1418349a0c3cb12d66db7d607e4cf06662d
Diff: https://reviews.apache.org/r/67136/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 67136: Added a function to get rlimits.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On May 17, 2018, 11:07 p.m., James Peach wrote:
> > src/posix/rlimits.cpp
> > Lines 147 (patched)
> > <https://reviews.apache.org/r/67136/diff/1/?file=2023057#file2023057line147>
> >
> > Use `ErrnoError` (also in the rest of the file if you feel like it).
Done, also snuck in a fix for the one above.
> On May 17, 2018, 11:07 p.m., James Peach wrote:
> > src/posix/rlimits.cpp
> > Lines 155 (patched)
> > <https://reviews.apache.org/r/67136/diff/1/?file=2023057#file2023057line155>
> >
> > I expected that RVO would kick in and eliminate the copy here?
This function is not a candidate for NRVO as the type of `limit` is different from the functions return value type (`RLimitInfo::RLimit` vs. `Try<RLimitInfo::RLimit>).
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67136/#review203373
-----------------------------------------------------------
On May 18, 2018, 2:36 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67136/
> -----------------------------------------------------------
>
> (Updated May 18, 2018, 2:36 p.m.)
>
>
> Review request for mesos, Jie Yu and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a function to get rlimits.
>
>
> Diffs
> -----
>
> src/posix/rlimits.hpp 0cc4d8aa58e400c0509969acdb5bd30bf89146da
> src/posix/rlimits.cpp 6446c1418349a0c3cb12d66db7d607e4cf06662d
>
>
> Diff: https://reviews.apache.org/r/67136/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67136: Added a function to get rlimits.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67136/#review203373
-----------------------------------------------------------
Fix it, then Ship it!
src/posix/rlimits.cpp
Lines 147 (patched)
<https://reviews.apache.org/r/67136/#comment285551>
Use `ErrnoError` (also in the rest of the file if you feel like it).
src/posix/rlimits.cpp
Lines 155 (patched)
<https://reviews.apache.org/r/67136/#comment285555>
I expected that RVO would kick in and eliminate the copy here?
- James Peach
On May 15, 2018, 4:19 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67136/
> -----------------------------------------------------------
>
> (Updated May 15, 2018, 4:19 p.m.)
>
>
> Review request for mesos, Jie Yu and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a function to get rlimits.
>
>
> Diffs
> -----
>
> src/posix/rlimits.hpp 0cc4d8aa58e400c0509969acdb5bd30bf89146da
> src/posix/rlimits.cpp 6446c1418349a0c3cb12d66db7d607e4cf06662d
>
>
> Diff: https://reviews.apache.org/r/67136/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67136: Added a function to get rlimits.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67136/#review203380
-----------------------------------------------------------
PASS: Mesos patch 67136 was successfully built and tested.
Reviews applied: `['67136']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67136
- Mesos Reviewbot Windows
On May 15, 2018, 4:19 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67136/
> -----------------------------------------------------------
>
> (Updated May 15, 2018, 4:19 p.m.)
>
>
> Review request for mesos, Jie Yu and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a function to get rlimits.
>
>
> Diffs
> -----
>
> src/posix/rlimits.hpp 0cc4d8aa58e400c0509969acdb5bd30bf89146da
> src/posix/rlimits.cpp 6446c1418349a0c3cb12d66db7d607e4cf06662d
>
>
> Diff: https://reviews.apache.org/r/67136/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67136: Added a function to get rlimits.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67136/#review203486
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67136]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 18, 2018, 2:36 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67136/
> -----------------------------------------------------------
>
> (Updated May 18, 2018, 2:36 p.m.)
>
>
> Review request for mesos, Jie Yu and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a function to get rlimits.
>
>
> Diffs
> -----
>
> src/posix/rlimits.hpp 0cc4d8aa58e400c0509969acdb5bd30bf89146da
> src/posix/rlimits.cpp 6446c1418349a0c3cb12d66db7d607e4cf06662d
>
>
> Diff: https://reviews.apache.org/r/67136/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67136: Added a function to get rlimits.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67136/#review203416
-----------------------------------------------------------
PASS: Mesos patch 67136 was successfully built and tested.
Reviews applied: `['67136']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67136
- Mesos Reviewbot Windows
On May 18, 2018, 2:36 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67136/
> -----------------------------------------------------------
>
> (Updated May 18, 2018, 2:36 p.m.)
>
>
> Review request for mesos, Jie Yu and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a function to get rlimits.
>
>
> Diffs
> -----
>
> src/posix/rlimits.hpp 0cc4d8aa58e400c0509969acdb5bd30bf89146da
> src/posix/rlimits.cpp 6446c1418349a0c3cb12d66db7d607e4cf06662d
>
>
> Diff: https://reviews.apache.org/r/67136/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67136: Added a function to get rlimits.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
> On Nov. 24, 2018, 1:17 a.m., Till Toenshoff wrote:
> > Thanks for adding this Benjamin - also thanks James for reviewing!
Just realized that we should consider moving this into stout, no?
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67136/#review210838
-----------------------------------------------------------
On May 18, 2018, 12:36 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67136/
> -----------------------------------------------------------
>
> (Updated May 18, 2018, 12:36 p.m.)
>
>
> Review request for mesos, Jie Yu and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a function to get rlimits.
>
>
> Diffs
> -----
>
> src/posix/rlimits.hpp 0cc4d8aa58e400c0509969acdb5bd30bf89146da
> src/posix/rlimits.cpp 6446c1418349a0c3cb12d66db7d607e4cf06662d
>
>
> Diff: https://reviews.apache.org/r/67136/diff/4/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67136: Added a function to get rlimits.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Nov. 24, 2018, 2:17 vorm., Till Toenshoff wrote:
> > Thanks for adding this Benjamin - also thanks James for reviewing!
>
> Till Toenshoff wrote:
> Just realized that we should consider moving this into stout, no?
That makes sense. We should then make this function independent of Mesos protos which would introduce another indirection.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67136/#review210838
-----------------------------------------------------------
On Mai 18, 2018, 2:36 nachm., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67136/
> -----------------------------------------------------------
>
> (Updated Mai 18, 2018, 2:36 nachm.)
>
>
> Review request for mesos, Jie Yu and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a function to get rlimits.
>
>
> Diffs
> -----
>
> src/posix/rlimits.hpp 0cc4d8aa58e400c0509969acdb5bd30bf89146da
> src/posix/rlimits.cpp 6446c1418349a0c3cb12d66db7d607e4cf06662d
>
>
> Diff: https://reviews.apache.org/r/67136/diff/4/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67136: Added a function to get rlimits.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67136/#review210838
-----------------------------------------------------------
Fix it, then Ship it!
Thanks for adding this Benjamin - also thanks James for reviewing!
src/posix/rlimits.cpp
Line 130 (original), 130 (patched)
<https://reviews.apache.org/r/67136/#comment295597>
Thanks for fixing this!
src/posix/rlimits.cpp
Lines 140 (patched)
<https://reviews.apache.org/r/67136/#comment295596>
Let's kill this blank OR add more blsnks to the rest to make the entire picture a bit more consistent.
Adjusting while committing - leaving this open for your entertainment.
- Till Toenshoff
On May 18, 2018, 12:36 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67136/
> -----------------------------------------------------------
>
> (Updated May 18, 2018, 12:36 p.m.)
>
>
> Review request for mesos, Jie Yu and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a function to get rlimits.
>
>
> Diffs
> -----
>
> src/posix/rlimits.hpp 0cc4d8aa58e400c0509969acdb5bd30bf89146da
> src/posix/rlimits.cpp 6446c1418349a0c3cb12d66db7d607e4cf06662d
>
>
> Diff: https://reviews.apache.org/r/67136/diff/4/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67136: Added a function to get rlimits.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67136/
-----------------------------------------------------------
(Updated May 18, 2018, 2:36 p.m.)
Review request for mesos, Jie Yu and James Peach.
Changes
-------
Addressed James' comments.
Repository: mesos
Description
-------
Added a function to get rlimits.
Diffs (updated)
-----
src/posix/rlimits.hpp 0cc4d8aa58e400c0509969acdb5bd30bf89146da
src/posix/rlimits.cpp 6446c1418349a0c3cb12d66db7d607e4cf06662d
Diff: https://reviews.apache.org/r/67136/diff/2/
Changes: https://reviews.apache.org/r/67136/diff/1-2/
Testing
-------
`make check`
Thanks,
Benjamin Bannier