[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #34568: Fix: make dry run optional for patch task instance

["ephraimbuddy (via GitHub)" <gi...@apache.org>]

ephraimbuddy commented on code in PR #34568:
URL: https://github.com/apache/airflow/pull/34568#discussion_r1335828609


##########
airflow/api_connexion/openapi/v1.yaml:
##########
@@ -4302,7 +4302,7 @@ components:
             If set, don't actually run this operation. The response will contain the task instance
             planned to be affected, but won't be modified in any way.
           type: boolean
-          default: false
+          default: true

Review Comment:
   This should be false



##########
airflow/api_connexion/schemas/task_instance_schema.py:
##########
@@ -180,7 +180,7 @@ def validate_form(self, data, **kwargs):
 class SetSingleTaskInstanceStateFormSchema(Schema):
     """Schema for handling the request of updating state of a single task instance."""
 
-    dry_run = fields.Boolean(dump_default=True)
+    dry_run = fields.Boolean(dump_default=True, load_default=True)

Review Comment:
   Not needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org