[GitHub] [incubator-superset] ktmud commented on pull request #10884: fix(cypress): wait for filterValues request

[GitBox <gi...@apache.org>]

ktmud commented on pull request #10884:
URL: https://github.com/apache/incubator-superset/pull/10884#issuecomment-692974261


   @nytai  Yeah, it's really strange that it only fails in my fork but it shouldn't really matter if it's not happening for everyone else.
   
   Although I was still seeing `AdhocFilters` failing after rebasing to this fix: https://github.com/apache/incubator-superset/pull/10837/checks?check_run_id=1119508451
   
   So I made another attempt to fix it: https://github.com/apache/incubator-superset/pull/10837/commits/4477fdd5a1ecdbc4eeaa8ceb8575d729bd2960c8
   
   Based on my previous experience, there seems to be some flakiness related to `cy.get(...).within(...)` so I removed the `within` calls.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org