You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/07/21 10:21:00 UTC

[GitHub] [zeppelin] rickchengx opened a new pull request #4184: [ZEPPELIN-5465] SERVICE_DOMAIN may be null while Zeppelin server is running outside k8s

rickchengx opened a new pull request #4184:
URL: https://github.com/apache/zeppelin/pull/4184


   ### What is this PR for?
   The function `sparkUiWebUrlFromTemplate` needs to use the variable `SERVICE_DOMAIN` to bind the `jinjava` template, which sets the environment variable `SERVICE_DOMAIN` as the default value.
   However, user may not set the environment variable when Zeppelin server is running outside of k8s, and it will get a NullPointerExcepetion:
   ```
   NullPointerException: null value in entry: SERVICE_DOMAIN=null
   ```
   
   When the user does not care about `zeppelin.spark.uiWebUrl`, he does not need to set the `SERVICE_DOMAIN` environment.
   
   So this PR change the default value of `SERVICE_DOMAIN` to `local.zeppelin-project.org` if `System.getenv(ENV_SERVICE_DOMAIN) == null` to avoid the potential NullPointerExcepetion.
   
   
   ### What type of PR is it?
   [Improvement]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * <https://issues.apache.org/jira/browse/ZEPPELIN-5465>
   
   ### How should this be tested?
   * CI pass and manually tested
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu commented on pull request #4184: [ZEPPELIN-5465] SERVICE_DOMAIN may be null while Zeppelin server is running outside k8s

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4184:
URL: https://github.com/apache/zeppelin/pull/4184#issuecomment-887459815


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] asfgit closed pull request #4184: [ZEPPELIN-5465] SERVICE_DOMAIN may be null while Zeppelin server is running outside k8s

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4184:
URL: https://github.com/apache/zeppelin/pull/4184


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org