You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2023/01/03 17:23:01 UTC

[GitHub] [tvm] janetsc opened a new pull request, #13685: Aot module post-test error workaround

janetsc opened a new pull request, #13685:
URL: https://github.com/apache/tvm/pull/13685

   The deletion of the AotModule python object results in the device shutting down RPC to early, causing an assertion in the DSP.  This is a temporary workaround while this is still being investigated.  The workaround is to keep a reference to the AotModule object in the HexagonSession object, so it stays until the session has been shut down.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] janetsc commented on a diff in pull request #13685: Aot module post-test error workaround

Posted by GitBox <gi...@apache.org>.
janetsc commented on code in PR #13685:
URL: https://github.com/apache/tvm/pull/13685#discussion_r1065252187


##########
python/tvm/contrib/hexagon/session.py:
##########
@@ -248,8 +248,8 @@ def get_aot_executor(
         GraphModule :
             Runtime graph module that can be used to execute the graph.
         """
-        aot_mod = self.load_module(module_file)
-        return tvm.runtime.executor.AotModule(aot_mod["default"](self.device))

Review Comment:
   Filed https://github.com/apache/tvm/issues/13741



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] mehrdadh merged pull request #13685: [AOT]Aot module post-test error workaround

Posted by GitBox <gi...@apache.org>.
mehrdadh merged PR #13685:
URL: https://github.com/apache/tvm/pull/13685


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] janetsc commented on a diff in pull request #13685: Aot module post-test error workaround

Posted by GitBox <gi...@apache.org>.
janetsc commented on code in PR #13685:
URL: https://github.com/apache/tvm/pull/13685#discussion_r1065252187


##########
python/tvm/contrib/hexagon/session.py:
##########
@@ -248,8 +248,8 @@ def get_aot_executor(
         GraphModule :
             Runtime graph module that can be used to execute the graph.
         """
-        aot_mod = self.load_module(module_file)
-        return tvm.runtime.executor.AotModule(aot_mod["default"](self.device))

Review Comment:
   Thanks for the review!  Filed https://github.com/apache/tvm/issues/13741



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #13685: Aot module post-test error workaround

Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13685:
URL: https://github.com/apache/tvm/pull/13685#issuecomment-1370033671

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] mehrdadh commented on a diff in pull request #13685: Aot module post-test error workaround

Posted by GitBox <gi...@apache.org>.
mehrdadh commented on code in PR #13685:
URL: https://github.com/apache/tvm/pull/13685#discussion_r1065209456


##########
python/tvm/contrib/hexagon/session.py:
##########
@@ -248,8 +248,8 @@ def get_aot_executor(
         GraphModule :
             Runtime graph module that can be used to execute the graph.
         """
-        aot_mod = self.load_module(module_file)
-        return tvm.runtime.executor.AotModule(aot_mod["default"](self.device))

Review Comment:
   Please add a github issue describing the problem and link it here. Also mention that this is a temporary fix



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org