[GitHub] [iceberg] szehon-ho commented on a diff in pull request #4520: Core: Files table predicate filtering wrong for tables with evolved partition specs

[GitBox <gi...@apache.org>]

szehon-ho commented on code in PR #4520:
URL: https://github.com/apache/iceberg/pull/4520#discussion_r844654243


##########
core/src/test/java/org/apache/iceberg/TestMetadataTableFilters.java:
##########
@@ -252,6 +254,74 @@ public void testPlanTasks() {
     validateCombinedScanTasks(tasks, 0);
   }
 
+  @Test
+  public void testPartitionSpecEvolution() {
+    Assume.assumeTrue(formatVersion == 2);

Review Comment:
   It is pretty tricky to have the same code work in v1 and v2 to change spec and write new files, so choosing to do this in v2 (should be orthogonal to the problem).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org