[GitHub] vvraskin commented on a change in pull request #3451: Fix several loadbalancer bugs.

[GitBox <gi...@apache.org>]

vvraskin commented on a change in pull request #3451: Fix several loadbalancer bugs.
URL: https://github.com/apache/incubator-openwhisk/pull/3451#discussion_r175506456
 
 

 ##########
 File path: core/controller/src/main/scala/whisk/core/loadBalancer/ShardingContainerPoolBalancer.scala
 ##########
 @@ -71,6 +72,10 @@ class ShardingContainerPoolBalancer(config: WhiskConfig, controllerInstance: Ins
   /** State needed for scheduling. */
   private val schedulingState = ShardingContainerPoolBalancerState()()
 
+  actorSystem.scheduler.schedule(0.seconds, 10.seconds) {
 
 Review comment:
   It might be better to use 60s interval on par with the statsd interval due to the way kamon ingests the metrics to statsd. It sends both histogram and gauges as timers, which forces our statsd plugin to take an average over all received values since the last push which might cause some noise in the resulting metric value, e.g. result in non-integer values after rounding. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services