[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #3939: Add optimizer test for simplifying predicates on timestamps

[GitBox <gi...@apache.org>]

alamb commented on code in PR #3939:
URL: https://github.com/apache/arrow-datafusion/pull/3939#discussion_r1003364471


##########
datafusion/optimizer/tests/integration-test.rs:
##########
@@ -87,11 +88,11 @@ fn case_when_aggregate() -> Result<()> {
 
 #[test]
 fn unsigned_target_type() -> Result<()> {
-    let sql = "SELECT * FROM test WHERE col_uint32 > 0";
+    let sql = "SELECT col_utf8 FROM test WHERE col_uint32 > 0";

Review Comment:
   As I added some columns to the test data I changed these plans so they selected specific columns rather than `SELECT *` so they didn't diff when the schema changed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org