[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5734: Adding column name rewrite for the identifiers in the format of [table].[column]

[GitBox <gi...@apache.org>]

fx19880617 commented on a change in pull request #5734:
URL: https://github.com/apache/incubator-pinot/pull/5734#discussion_r459675209



##########
File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -450,18 +448,22 @@ public BrokerResponse handleRequest(JsonNode request, @Nullable RequesterIdentit
   private void updateQuerySource(BrokerRequest brokerRequest) {
     String tableName = brokerRequest.getQuerySource().getTableName();
     // Check if table is in the format of [database_name].[table_name]
-    String[] tableNameSplits = StringUtils.split(tableName, '.');
-    if (tableNameSplits.length != 2) {
-      return;
-    }
+    String[] tableNameSplits = StringUtils.split(tableName, ".", 2);

Review comment:
       Calcite doesn't support parse it as [table].[column], we will get the whole as identifier.
   Then we need to handle that.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org