You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/04/04 14:11:00 UTC

Review Request 58174: Fixed the signatures of some test helpers.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58174/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar and Vinod Kone.


Repository: mesos


Description
-------

This patch fixes some test helpers for
'CombinedAuthenticatorTest.MultipleAuthenticators' to
accept their parameters as const ref.


Diffs
-----

  src/tests/http_authentication_tests.cpp 36d2b73fa3d0f65aed5e37fe661c93dd46132f82 


Diff: https://reviews.apache.org/r/58174/diff/1/


Testing
-------

`make && bin/mesos-tests.sh --gtest_filter="CombinedAuthenticatorTest.MultipleAuthenticators"`


Thanks,

Greg Mann

Re: Review Request 58174: Fixed the signatures of some test helpers.

Posted by Anand Mazumdar <an...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58174/#review170986
-----------------------------------------------------------


Ship it!




Ship It!

- Anand Mazumdar


On April 4, 2017, 2:11 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58174/
> -----------------------------------------------------------
> 
> (Updated April 4, 2017, 2:11 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch fixes some test helpers for
> 'CombinedAuthenticatorTest.MultipleAuthenticators' to
> accept their parameters as const ref.
> 
> 
> Diffs
> -----
> 
>   src/tests/http_authentication_tests.cpp 36d2b73fa3d0f65aed5e37fe661c93dd46132f82 
> 
> 
> Diff: https://reviews.apache.org/r/58174/diff/1/
> 
> 
> Testing
> -------
> 
> `make && bin/mesos-tests.sh --gtest_filter="CombinedAuthenticatorTest.MultipleAuthenticators"`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>