You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by masaori335 <gi...@git.apache.org> on 2016/08/09 07:39:57 UTC
[GitHub] trafficserver pull request #846: TS-4726: Remove unnecessary assert in Proxy...
GitHub user masaori335 opened a pull request:
https://github.com/apache/trafficserver/pull/846
TS-4726: Remove unnecessary assert in ProxyClientTransaction::release
[TS-4726](https://issues.apache.org/jira/browse/TS-4726)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/masaori335/trafficserver ts-4726
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/846.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #846
----
commit d3ae487d9f7f9350b57f628aa25d39c8e829ad7d
Author: Masaori Koshiba <ma...@apache.org>
Date: 2016-08-09T07:32:29Z
TS-4726: Remove unnecessary assert in ProxyClientTransaction::release
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #846: TS-4726: Remove unnecessary assert in ProxyClientT...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/846
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/512/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #846: TS-4726: Remove unnecessary assert in ProxyClientT...
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/846
Yes, we should land it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #846: TS-4726: Remove unnecessary assert in ProxyClientT...
Posted by JamesPeach <gi...@git.apache.org>.
Github user JamesPeach commented on the issue:
https://github.com/apache/trafficserver/pull/846
Is the reader actually *guaranteed* to be NULL here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #846: TS-4726: Remove unnecessary assert in ProxyClientT...
Posted by masaori335 <gi...@git.apache.org>.
Github user masaori335 commented on the issue:
https://github.com/apache/trafficserver/pull/846
Yes, it is moved to `ProxyClientTransaction::destroy()` by TS-4507
https://github.com/apache/trafficserver/blob/master/proxy/ProxyClientTransaction.cc#L85
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #846: TS-4726: Remove unnecessary assert in ProxyClientT...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/846
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/409/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #846: TS-4726: Remove unnecessary assert in ProxyClientT...
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/846
Agreed that the assert doesn't mean much at this point.
current_reader (the HttpSM) may be NULL here or not. If the StateMachine calls ua_session->release then it will not be null. But Http2Stream::release() calls do_io_close which calls super::release() again for good measure. The second time through current_reader will be NULL.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #846: TS-4726: Remove unnecessary assert in ProxyClientT...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/846
I think I see this, we only set current_reader=NULL after that assert, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #846: TS-4726: Remove unnecessary assert in ProxyClientT...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/846
Should we land this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #846: TS-4726: Remove unnecessary assert in Proxy...
Posted by masaori335 <gi...@git.apache.org>.
Github user masaori335 closed the pull request at:
https://github.com/apache/trafficserver/pull/846
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---