You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/04 15:14:00 UTC

[GitHub] [airflow] jstern commented on issue #7133: [AIRFLOW-6535] add exception to fail without retry

jstern commented on issue #7133: [AIRFLOW-6535] add exception to fail without retry
URL: https://github.com/apache/airflow/pull/7133#issuecomment-581956730
 
 
   > The one thing I don't think the tests cover is that actually raising this new exception causes the task to not be retried -- you've tested the change to handle_failure, but that is essentially the internal details, rather than the "interface" of the new feature.
   
   I'll take some time to look deeper but I didn't find any existing tests of the interface for handling the other exceptions, so I glommed onto the closest test I could find. If you know offhand where better example tests that I can extend please point me to them :) Or I can try to take some time to add them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services