[GitHub] [airflow] alexbegg commented on issue #9036: Task instance log_filepath doesn't include try_number

[GitBox <gi...@apache.org>]

alexbegg commented on issue #9036:
URL: https://github.com/apache/airflow/issues/9036#issuecomment-677941227


   @mik-laj Is there an example of how to utilize `FileProcessorHandler` to get the log file path? The only thing I can find in the clode base to get a log file path that actually utilizes the correct `LOG_FILENAME_TEMPLATE` is:
   https://github.com/apache/airflow/blob/c35a01037ad4bb03d39a0319d37bc36b08ccf766/airflow/utils/helpers.py#L154 and https://github.com/apache/airflow/blob/c35a01037ad4bb03d39a0319d37bc36b08ccf766/airflow/utils/log/log_reader.py#L109
   
   ...
   
   Also, the deprecated `log_filepath` method is still used in https://github.com/apache/airflow/blob/010322692e6e3f0adc156f0beb81e267da0e97bb/airflow/models/taskinstance.py#L1612-L1619 so it is showing the wrong path in emails and I would like to try and fix it and submit a PR.
   
   Also since it can still be wrong in people's custom `html_content_template` as well because it has for a long time been shown in the docs page https://github.com/apache/airflow/blob/ba00db3d6cfbef2390c045edfeacf67e133513eb/docs/howto/email-config.rst#L50 I think it will be best to just fix `log_filepath` to utilize the new method to get the log path instead of deleting the property.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org