You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2022/11/16 16:24:59 UTC

[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #52: require PR reviews and linear history

pjfanning commented on code in PR #52:
URL: https://github.com/apache/incubator-pekko/pull/52#discussion_r1024228478


##########
.asf.yaml:
##########
@@ -28,7 +28,21 @@ github:
     rebase:  true
 
   protected_branches:
-    main: { }
+    main:
+      required_status_checks:
+        # strict means "Require branches to be up to date before merging".
+        strict: false
+        # contexts are the names of checks that must pass
+        contexts:
+          - Scalafmt
+  
+      required_pull_request_reviews:
+        dismiss_stale_reviews: false
+        require_code_owner_reviews: false
+        required_approving_review_count: 1

Review Comment:
   only 1 review needed for trivial changes according to https://cwiki.apache.org/confluence/display/PEKKO/Processes - there is no way to work out automatically what is trivial



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org