[jira] [Updated] (LUCENE-7155) Script addVersion.py does not detect the new naming convention for bugfix branches

["Jan Høydahl (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-7155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Høydahl updated LUCENE-7155:
--------------------------------
    Attachment: LUCENE-7155-improve.patch

addVersion.py currently checks for {{c.branch_type == 'major'}} which will never occur since valid values are release, stable, master. What was the intent behind this code?

Attaching patch which
* Uses an enum for equality checks of branch type
* SVN changeId -> Git changeId in help text
* Bail out with sane error msg if attempting to add bugfix ver to master/stable without {{--changeid}}, and ditto when adding minor ver to master

> Script addVersion.py does not detect the new naming convention for bugfix branches
> ----------------------------------------------------------------------------------
>
>                 Key: LUCENE-7155
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7155
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: -tools
>    Affects Versions: 5.5, master, 6.0, 6.x
>            Reporter: Jan Høydahl
>            Assignee: Jan Høydahl
>             Fix For: 5.5, master
>
>         Attachments: LUCENE-7155-improve.patch, LUCENE-7155.patch
>
>
> Spinoff from LUCENE-6938. Earlier we named release branches {{lucene_solr_X_Y}} while now we name them {{branch_X_Y}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org