You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/27 21:08:54 UTC

[GitHub] [airflow] potiuk edited a comment on pull request #20239: switch to follow_redirects on httpx.get call in CloudSQL provider

potiuk edited a comment on pull request #20239:
URL: https://github.com/apache/airflow/pull/20239#issuecomment-1001761604


   > Sure. I can't oversee the consequences nearly as good, so I would just follow your suggestion. Sensing is a nice idea, but just try/except is more "pythonic" (EAFP), isn't it? I would go for that later.
   
   Both would work, I guess, but I think checking for attr is more explicit IMHO and better expresses the intent. Also same exception can be thrown if you happen to pass another parameter which is unexpected which might hide another error/typo


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org