You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2019/04/17 14:43:04 UTC

[GitHub] [hbase] infraio commented on a change in pull request #155: HBASE-22244 Make use of MetricsConnection in async client

infraio commented on a change in pull request #155: HBASE-22244 Make use of MetricsConnection in async client
URL: https://github.com/apache/hbase/pull/155#discussion_r276277091
 
 

 ##########
 File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
 ##########
 @@ -190,10 +190,10 @@
 
   // thread executor shared by all Table instances created
   // by this connection
-  private volatile ExecutorService batchPool = null;
+  private volatile ThreadPoolExecutor batchPool = null;
 
 Review comment:
   Why change this to ThreadPoolExecutor? Because MetricsConnection need this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services