You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Michael Semb Wever (Jira)" <ji...@apache.org> on 2021/04/29 22:49:00 UTC
[jira] [Comment Edited] (CASSANDRA-16630) Migrate to JUnit5
[ https://issues.apache.org/jira/browse/CASSANDRA-16630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17335855#comment-17335855 ]
Michael Semb Wever edited comment on CASSANDRA-16630 at 4/29/21, 10:48 PM:
---------------------------------------------------------------------------
bq. Is it critical for us to save the existing output as is?
My first answer is yes.
But we'll need to look into each specifically, and dig through the history, and think about third-party testing setups that depend on them…
For example I know that {{CassandraXMLJUnitResultFormatter}} is important as we parameterise test runs with the {{-Dcassandra.testtag=…}} jvm flag, and junit reports and [aggregated|https://github.com/apache/cassandra-builds/blob/trunk/jenkins-dsl/cassandra_job_dsl_seed.groovy#L461-L483] over stage job matrixes and over the [whole|https://github.com/apache/cassandra/blob/trunk/.jenkins/Jenkinsfile#L339-L367] ci pipeline.
This work will need to include the build scripts [here|https://github.com/apache/cassandra-builds/tree/trunk/build-scripts], the circleci [yaml|https://github.com/apache/cassandra/tree/trunk/.circleci] in-tree, and the jenkins [dsl|https://github.com/apache/cassandra-builds/blob/trunk/jenkins-dsl/cassandra_job_dsl_seed.groovy] and declarative [jenkinsfiles|https://github.com/apache/cassandra/tree/trunk/.jenkins]. A challenge we will have with the build-scripts is that they are not versioned, that is the trunk build-scripts have to work for every supported cassandra release branch (2.2, 3.0, 3.11, 4.0 and trunk)
was (Author: michaelsembwever):
bq. Is it critical for us to save the existing output as is?
My first answer is yes.
But we'll need to look into each specifically, and dig through the history, and think about third-party testing setups that depend on them…
For example I know that {{CassandraXMLJUnitResultFormatter}} is important as we parameterise test runs with the {{-Dcassandra.testtag=…}} jvm flag, and junit reports and aggregated over stage job matrixes and over the whole ci pipeline.
This work will need to include the build scripts [here|https://github.com/apache/cassandra-builds/tree/trunk/build-scripts], the circleci [yaml|https://github.com/apache/cassandra/tree/trunk/.circleci] in-tree, and the jenkins [dsl|https://github.com/apache/cassandra-builds/blob/trunk/jenkins-dsl/cassandra_job_dsl_seed.groovy] and declarative [jenkinsfiles|https://github.com/apache/cassandra/tree/trunk/.jenkins]. A challenge we will have with the build-scripts is that they are not versioned, that is the trunk build-scripts have to work for every supported cassandra release branch (2.2, 3.0, 3.11, 4.0 and trunk)
> Migrate to JUnit5
> -----------------
>
> Key: CASSANDRA-16630
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16630
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/unit
> Reporter: Alexey Zotov
> Assignee: Alexey Zotov
> Priority: Low
>
> h3. Overview
> Currently C* uses JUnit4 (version 4.12) which is obsolete. There is a newer version 4.13.2 which we could update to. However, JUnit4 is generally considered to be outdated and it is reasonable to migrate to JUnit5.
> Despite of having a syntax sugar in JUnit5 (assertThrow, lamda's support, ect), there are no blockers that push us to move from JUnit4. The main motivation for this initiative is rule of thumb to use up-to-date versions of the dependencies.
> Obviously this change is not backward compatible with the open PRs and previous C* versions. Therefore, it will require an additional effort for backporting the changes and updating PRs that have tests. However, I believe it should not be a blocker for this initiative.
> h3. Scope (preliminary list)
> # change JUnit4 to JUnit5 dependencies and make necessary changes in ant tasks (https://ant.apache.org/manual/Tasks/junitlauncher.html)
> # update syntax in all tests (imports, Before/After annotations, etc)
> # update parameterized tests
> # create a new version of {{OrderedJUnit4ClassRunner}} and update corresponding tests
> # update tests that use {{BMUnitRunner}} (as per https://developer.jboss.org/docs/DOC-52953 it supports JUnit5)
> # update tests with {{@Rule}}
> # update tests with expected exceptions
> h3. Order of operations
> In order to make the transition more smooth we want to use a phased approach:
> # migrate to JUnit5 with [Vintage Engine|https://junit.org/junit5/docs/current/user-guide/#dependency-metadata-junit-vintage], so all JUnit4 tests work as is
> # update tests in a few bunches (to not have a huge single PR with numerous conflicts)
> # disable (remove dependency) Vintage Engine, so only JUnit5 tests work
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org