You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jscheffl (via GitHub)" <gi...@apache.org> on 2025/10/31 20:50:38 UTC

[PR] Enable ruff PLW1508 rule [airflow]

jscheffl opened a new pull request, #57653:
URL: https://github.com/apache/airflow/pull/57653

   While implementing https://github.com/apache/airflow/pull/57294 I realized that a couple of more ruff PLW rules might be interesting, this PR enables PLW1508 - and adds fixes as needed.
   
   Alongside saw that the following needed no fixes and enabled them as well:
   - PLW0604: global at module level is redundant
   - PLW0642: Reassigned {} variable in {method_type} method
   - PLW0711: Exception to catch is the result of a binary and operation
   - PLW1501: {mode} is not a valid mode for open
   - PLW1507: Shallow copy of os.environ via copy.copy(os.environ)
   
   See also https://docs.astral.sh/ruff/rules/#warning-plw


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Enable ruff PLW1508 rule [airflow]

Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl merged PR #57653:
URL: https://github.com/apache/airflow/pull/57653


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Enable ruff PLW1508 rule [airflow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57653:
URL: https://github.com/apache/airflow/pull/57653#issuecomment-3476026640

   ### Backport failed to create: v3-1-test. View the failure log <a href='https://github.com/apache/airflow/actions/runs/18994473618'> Run details </a>
   
   <table>
       <tr>
           <th>Status</th>
           <th>Branch</th>
           <th>Result</th>
       </tr>
       <tr>
           <td>❌</td>
           <td>v3-1-test</td>
           <td><a href="https://github.com/apache/airflow/commit/c846f6f27fe97ebd00cc0a13cf7ee59f1020877b"><img src='https://img.shields.io/badge/Commit-c846f6f-red' alt='Commit Link'></a></td>
       </tr>
   </table>
   
   You can attempt to backport this manually by running:
   
   ```bash
   cherry_picker c846f6f v3-1-test
   ```
   
   This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
   the files that need manual conflict resolution.
   
   After you have resolved the conflicts, you can continue the backport process by running:
   
   ```bash
   cherry_picker --continue
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org