You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2026/10/06 16:54:21 UTC
[kudu-CR] KUDU-3813 fix flakiness in txn commit-itest scenarios
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/25029
Change subject: KUDU-3813 fix flakiness in txn_commit-itest scenarios
......................................................................
KUDU-3813 fix flakiness in txn_commit-itest scenarios
With very short keepalive interval setting for transactions, test
scenarios would fail from time to time in TSAN builds. For example,the
TestDontBackgroundAbortIfCommitInProgress scenario would intermittently
fail as described in the JIRA item. This changelist increases the
keepalive interval from 300ms to 500ms, and also increases verification
time interval from 100ms to 250ms. With this, a wider margin is
provided to cover for scheduler anomalies and other TSAN-induced pauses
at overloaded test nodes.
I ran 5K iterations of the TestDontBackgroundAbortIfCommitInProgress
scenario and about 500 iterations of all the scenarios in TSAN
instrumented txn_commit-itest with --stress-cpu-threads=8 after this
update and there were no failures reported.
Change-Id: I58746e38866788c0ec6b9ebac96bc8ec1c23ca72
---
M src/kudu/integration-tests/txn_commit-itest.cc
1 file changed, 7 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/25029/1
--
To view, visit http://gerrit.cloudera.org:8080/25029
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I58746e38866788c0ec6b9ebac96bc8ec1c23ca72
Gerrit-Change-Number: 25029
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] KUDU-3813 fix flakiness in txn commit-itest scenarios
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/25029 )
Change subject: KUDU-3813 fix flakiness in txn_commit-itest scenarios
......................................................................
Patch Set 2: Verified+1
DEBUG: unrelated test failure in DeleteTabletITest.TestLeaderElectionDuringDeleteTablet
--
To view, visit http://gerrit.cloudera.org:8080/25029
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58746e38866788c0ec6b9ebac96bc8ec1c23ca72
Gerrit-Change-Number: 25029
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Oct 2026 02:00:36 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3813 fix flakiness in txn commit-itest scenarios
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/25029 )
Change subject: KUDU-3813 fix flakiness in txn_commit-itest scenarios
......................................................................
KUDU-3813 fix flakiness in txn_commit-itest scenarios
With very short keepalive interval setting for transactions, test
scenarios would fail from time to time in TSAN builds. For example,the
TestDontBackgroundAbortIfCommitInProgress scenario would intermittently
fail as described in the JIRA item. This changelist increases the
keepalive interval from 300ms to 500ms, and also increases verification
time interval from 100ms to 250ms. With this, a wider margin is
provided to cover for scheduler anomalies and other TSAN-induced pauses
at overloaded test nodes.
I ran 5K iterations of the TestDontBackgroundAbortIfCommitInProgress
scenario and about 500 iterations of all the scenarios in TSAN
instrumented txn_commit-itest with --stress-cpu-threads=8 after this
update and there were no failures reported.
Change-Id: I58746e38866788c0ec6b9ebac96bc8ec1c23ca72
Reviewed-on: http://gerrit.cloudera.org:8080/25029
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/integration-tests/txn_commit-itest.cc
1 file changed, 7 insertions(+), 3 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/25029
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I58746e38866788c0ec6b9ebac96bc8ec1c23ca72
Gerrit-Change-Number: 25029
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
[kudu-CR] KUDU-3813 fix flakiness in txn commit-itest scenarios
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25029 )
Change subject: KUDU-3813 fix flakiness in txn_commit-itest scenarios
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/3082/
--
To view, visit http://gerrit.cloudera.org:8080/25029
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58746e38866788c0ec6b9ebac96bc8ec1c23ca72
Gerrit-Change-Number: 25029
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 06 Oct 2026 16:54:28 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3813 fix flakiness in txn commit-itest scenarios
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25029 )
Change subject: KUDU-3813 fix flakiness in txn_commit-itest scenarios
......................................................................
Patch Set 2: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/3085/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/25029
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58746e38866788c0ec6b9ebac96bc8ec1c23ca72
Gerrit-Change-Number: 25029
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Oct 2026 00:11:41 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3813 fix flakiness in txn commit-itest scenarios
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25029 )
Change subject: KUDU-3813 fix flakiness in txn_commit-itest scenarios
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/3082/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/25029
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58746e38866788c0ec6b9ebac96bc8ec1c23ca72
Gerrit-Change-Number: 25029
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Oct 2026 18:50:02 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3813 fix flakiness in txn commit-itest scenarios
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-3813 fix flakiness in txn_commit-itest scenarios
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/25029
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I58746e38866788c0ec6b9ebac96bc8ec1c23ca72
Gerrit-Change-Number: 25029
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
[kudu-CR] KUDU-3813 fix flakiness in txn commit-itest scenarios
Posted by "Zoltan Martonka (Code Review)" <ge...@cloudera.org>.
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/25029 )
Change subject: KUDU-3813 fix flakiness in txn_commit-itest scenarios
......................................................................
Patch Set 1: Code-Review+2
+2, but master seems to be broken from a different commit, we should fix that before merging anything else.
--
To view, visit http://gerrit.cloudera.org:8080/25029
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58746e38866788c0ec6b9ebac96bc8ec1c23ca72
Gerrit-Change-Number: 25029
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Oct 2026 21:13:53 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3813 fix flakiness in txn commit-itest scenarios
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/25029 )
Change subject: KUDU-3813 fix flakiness in txn_commit-itest scenarios
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/25029
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58746e38866788c0ec6b9ebac96bc8ec1c23ca72
Gerrit-Change-Number: 25029
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Oct 2026 05:11:59 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3813 fix flakiness in txn commit-itest scenarios
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25029 )
Change subject: KUDU-3813 fix flakiness in txn_commit-itest scenarios
......................................................................
Patch Set 2:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/3085/
--
To view, visit http://gerrit.cloudera.org:8080/25029
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58746e38866788c0ec6b9ebac96bc8ec1c23ca72
Gerrit-Change-Number: 25029
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Oct 2026 23:10:34 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3813 fix flakiness in txn commit-itest scenarios
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/25029 )
Change subject: KUDU-3813 fix flakiness in txn_commit-itest scenarios
......................................................................
Patch Set 2: Code-Review+2
Carrying over Zoltan's +2 from PS1.
--
To view, visit http://gerrit.cloudera.org:8080/25029
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58746e38866788c0ec6b9ebac96bc8ec1c23ca72
Gerrit-Change-Number: 25029
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Oct 2026 02:00:55 +0000
Gerrit-HasComments: No