You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Bruno Busco (JIRA)" <ji...@apache.org> on 2010/11/28 19:47:37 UTC
[jira] Created: (OFBIZ-4037) Moving the user SignUp feature from
MyPortal to the Framework
Moving the user SignUp feature from MyPortal to the Framework
-------------------------------------------------------------
Key: OFBIZ-4037
URL: https://issues.apache.org/jira/browse/OFBIZ-4037
Project: OFBiz
Issue Type: Improvement
Components: framework
Affects Versions: SVN trunk
Reporter: Bruno Busco
Hi Devs!
In the attached patch I have reworked the feature that allows a new user to SignUp for an account.
This feature is actually only available when logging in at the MyPortal application.
Well, IMO it should be centrally available so that the login screen is exactly the same regardless of the application.
The Captcha feature is already implemented (captcha.java) partially in the framework and so this patch should be seen as a clean up also.
I added full internationalization of all labels and created some labels in the CommonUiLabels.xml file.
I would like some review so that I could then commit if nobody finds something wrong.
By the way, there is for sure some improvement that could be done at a later stage:
- Eliminate the labels that have been created in the CommonUiLabels from Party and MyPortal
- Add an encription of the Captcha code so that it will not be easily broken by robots.
Thank you for any comment you could provide.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4037) Moving the user SignUp feature from
MyPortal to the Framework
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966793#action_12966793 ]
Bruno Busco commented on OFBIZ-4037:
------------------------------------
As Hans suggests on the dev ML having the feature enabled would be better to show OOTB the feature.
Thank you Hans.
> Moving the user SignUp feature from MyPortal to the Framework
> -------------------------------------------------------------
>
> Key: OFBIZ-4037
> URL: https://issues.apache.org/jira/browse/OFBIZ-4037
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Attachments: ofbiz_signup.patch
>
>
> Hi Devs!
> In the attached patch I have reworked the feature that allows a new user to SignUp for an account.
> This feature is actually only available when logging in at the MyPortal application.
> Well, IMO it should be centrally available so that the login screen is exactly the same regardless of the application.
> The Captcha feature is already implemented (captcha.java) partially in the framework and so this patch should be seen as a clean up also.
> I added full internationalization of all labels and created some labels in the CommonUiLabels.xml file.
> I would like some review so that I could then commit if nobody finds something wrong.
> By the way, there is for sure some improvement that could be done at a later stage:
> - Eliminate the labels that have been created in the CommonUiLabels from Party and MyPortal
> - Add an encription of the Captcha code so that it will not be easily broken by robots.
> Thank you for any comment you could provide.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (OFBIZ-4037) Moving the user SignUp feature from
MyPortal to the Framework
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruno Busco reopened OFBIZ-4037:
--------------------------------
The commit has been reverted as suggested by Adam.
The reason was that the patch adds in the framework several dependencies from the applications (mainly Party).
A rework must be done.
A possible solution could be to move the register stuff to the commonext component instead of common.
What do you think?
> Moving the user SignUp feature from MyPortal to the Framework
> -------------------------------------------------------------
>
> Key: OFBIZ-4037
> URL: https://issues.apache.org/jira/browse/OFBIZ-4037
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Assignee: Bruno Busco
> Attachments: ofbiz_signup.patch
>
>
> Hi Devs!
> In the attached patch I have reworked the feature that allows a new user to SignUp for an account.
> This feature is actually only available when logging in at the MyPortal application.
> Well, IMO it should be centrally available so that the login screen is exactly the same regardless of the application.
> The Captcha feature is already implemented (captcha.java) partially in the framework and so this patch should be seen as a clean up also.
> I added full internationalization of all labels and created some labels in the CommonUiLabels.xml file.
> I would like some review so that I could then commit if nobody finds something wrong.
> By the way, there is for sure some improvement that could be done at a later stage:
> - Eliminate the labels that have been created in the CommonUiLabels from Party and MyPortal
> - Add an encription of the Captcha code so that it will not be easily broken by robots.
> Thank you for any comment you could provide.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-4037) Moving the user SignUp feature from
MyPortal to the Framework
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruno Busco closed OFBIZ-4037.
------------------------------
Resolution: Fixed
Assignee: Bruno Busco
Committed to the trunk At revision: 1042196
> Moving the user SignUp feature from MyPortal to the Framework
> -------------------------------------------------------------
>
> Key: OFBIZ-4037
> URL: https://issues.apache.org/jira/browse/OFBIZ-4037
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Assignee: Bruno Busco
> Attachments: ofbiz_signup.patch
>
>
> Hi Devs!
> In the attached patch I have reworked the feature that allows a new user to SignUp for an account.
> This feature is actually only available when logging in at the MyPortal application.
> Well, IMO it should be centrally available so that the login screen is exactly the same regardless of the application.
> The Captcha feature is already implemented (captcha.java) partially in the framework and so this patch should be seen as a clean up also.
> I added full internationalization of all labels and created some labels in the CommonUiLabels.xml file.
> I would like some review so that I could then commit if nobody finds something wrong.
> By the way, there is for sure some improvement that could be done at a later stage:
> - Eliminate the labels that have been created in the CommonUiLabels from Party and MyPortal
> - Add an encription of the Captcha code so that it will not be easily broken by robots.
> Thank you for any comment you could provide.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (OFBIZ-4037) Moving the user SignUp feature
from MyPortal to the Framework
Posted by Hans Bakker <ma...@antwebsystems.com>.
Because we want to show all features of OFBiz by default, i propose that
this feature should be initially enabled i.e. to be able to
register.....
On Fri, 2010-12-03 at 17:52 -0500, Bruno Busco (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/OFBIZ-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966712#action_12966712 ]
>
> Bruno Busco commented on OFBIZ-4037:
> ------------------------------------
>
> Hi,
> I would like to commit this patch.
> Does somebody see any issue?
>
> I would set the OOTB values for the configuration parameters so that the SignUp feature is enabled with Captcha code check.
> Are you OK with this setting or do you think that by default the feature should be disabled?
> Right now we have that it is disabled on all application but MyPortal.
> After the patch the feature will be enabled/disabled for all applications.
>
> > Moving the user SignUp feature from MyPortal to the Framework
> > -------------------------------------------------------------
> >
> > Key: OFBIZ-4037
> > URL: https://issues.apache.org/jira/browse/OFBIZ-4037
> > Project: OFBiz
> > Issue Type: Improvement
> > Components: framework
> > Affects Versions: SVN trunk
> > Reporter: Bruno Busco
> > Attachments: ofbiz_signup.patch
> >
> >
> > Hi Devs!
> > In the attached patch I have reworked the feature that allows a new user to SignUp for an account.
> > This feature is actually only available when logging in at the MyPortal application.
> > Well, IMO it should be centrally available so that the login screen is exactly the same regardless of the application.
> > The Captcha feature is already implemented (captcha.java) partially in the framework and so this patch should be seen as a clean up also.
> > I added full internationalization of all labels and created some labels in the CommonUiLabels.xml file.
> > I would like some review so that I could then commit if nobody finds something wrong.
> > By the way, there is for sure some improvement that could be done at a later stage:
> > - Eliminate the labels that have been created in the CommonUiLabels from Party and MyPortal
> > - Add an encription of the Captcha code so that it will not be easily broken by robots.
> > Thank you for any comment you could provide.
>
--
Ofbiz on twitter: http://twitter.com/apache_ofbiz
Myself on twitter: http://twitter.com/hansbak
Antwebsystems.com: Quality services for competitive rates.
[jira] Commented: (OFBIZ-4037) Moving the user SignUp feature from
MyPortal to the Framework
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966712#action_12966712 ]
Bruno Busco commented on OFBIZ-4037:
------------------------------------
Hi,
I would like to commit this patch.
Does somebody see any issue?
I would set the OOTB values for the configuration parameters so that the SignUp feature is enabled with Captcha code check.
Are you OK with this setting or do you think that by default the feature should be disabled?
Right now we have that it is disabled on all application but MyPortal.
After the patch the feature will be enabled/disabled for all applications.
> Moving the user SignUp feature from MyPortal to the Framework
> -------------------------------------------------------------
>
> Key: OFBIZ-4037
> URL: https://issues.apache.org/jira/browse/OFBIZ-4037
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Attachments: ofbiz_signup.patch
>
>
> Hi Devs!
> In the attached patch I have reworked the feature that allows a new user to SignUp for an account.
> This feature is actually only available when logging in at the MyPortal application.
> Well, IMO it should be centrally available so that the login screen is exactly the same regardless of the application.
> The Captcha feature is already implemented (captcha.java) partially in the framework and so this patch should be seen as a clean up also.
> I added full internationalization of all labels and created some labels in the CommonUiLabels.xml file.
> I would like some review so that I could then commit if nobody finds something wrong.
> By the way, there is for sure some improvement that could be done at a later stage:
> - Eliminate the labels that have been created in the CommonUiLabels from Party and MyPortal
> - Add an encription of the Captcha code so that it will not be easily broken by robots.
> Thank you for any comment you could provide.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4037) Moving the user SignUp feature from
MyPortal to the Framework
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruno Busco updated OFBIZ-4037:
-------------------------------
Attachment: ofbiz_signup.patch
> Moving the user SignUp feature from MyPortal to the Framework
> -------------------------------------------------------------
>
> Key: OFBIZ-4037
> URL: https://issues.apache.org/jira/browse/OFBIZ-4037
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Bruno Busco
> Attachments: ofbiz_signup.patch
>
>
> Hi Devs!
> In the attached patch I have reworked the feature that allows a new user to SignUp for an account.
> This feature is actually only available when logging in at the MyPortal application.
> Well, IMO it should be centrally available so that the login screen is exactly the same regardless of the application.
> The Captcha feature is already implemented (captcha.java) partially in the framework and so this patch should be seen as a clean up also.
> I added full internationalization of all labels and created some labels in the CommonUiLabels.xml file.
> I would like some review so that I could then commit if nobody finds something wrong.
> By the way, there is for sure some improvement that could be done at a later stage:
> - Eliminate the labels that have been created in the CommonUiLabels from Party and MyPortal
> - Add an encription of the Captcha code so that it will not be easily broken by robots.
> Thank you for any comment you could provide.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.