You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by gy...@apache.org on 2023/06/25 14:15:04 UTC
[flink-kubernetes-operator] 01/07: [cleanup] Remove unused diffbuilder code
This is an automated email from the ASF dual-hosted git repository.
gyfora pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/flink-kubernetes-operator.git
commit 4964bce58767e5744151721e9be92d3f2883072b
Author: Gyula Fora <g_...@apple.com>
AuthorDate: Wed May 10 09:46:38 2023 +0200
[cleanup] Remove unused diffbuilder code
---
.../operator/reconciler/diff/DiffBuilder.java | 102 ---------------------
1 file changed, 102 deletions(-)
diff --git a/flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/diff/DiffBuilder.java b/flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/diff/DiffBuilder.java
index 7c27eb88..cba89389 100644
--- a/flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/diff/DiffBuilder.java
+++ b/flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/diff/DiffBuilder.java
@@ -53,25 +53,6 @@ public class DiffBuilder<T> implements Builder<DiffResult<?>> {
this.triviallyEqual = before == after || before.equals(after);
}
- public DiffBuilder<T> testTriviallyEqual(boolean testTriviallyEqual) {
- this.triviallyEqual = this.triviallyEqual && testTriviallyEqual;
- return this;
- }
-
- public DiffBuilder<T> append(
- @NonNull final String fieldName,
- final boolean left,
- final boolean right,
- DiffType type) {
- if (triviallyEqual) {
- return this;
- }
- if (left != right) {
- diffs.add(new Diff<>(fieldName, left, right, type));
- }
- return this;
- }
-
public DiffBuilder<T> append(
@NonNull final String fieldName,
final boolean[] left,
@@ -86,17 +67,6 @@ public class DiffBuilder<T> implements Builder<DiffResult<?>> {
return this;
}
- public DiffBuilder<T> append(
- @NonNull final String fieldName, final byte left, final byte right, DiffType type) {
- if (triviallyEqual) {
- return this;
- }
- if (left != right) {
- diffs.add(new Diff<>(fieldName, left, right, type));
- }
- return this;
- }
-
public DiffBuilder<T> append(
@NonNull final String fieldName, final byte[] left, final byte[] right, DiffType type) {
@@ -109,18 +79,6 @@ public class DiffBuilder<T> implements Builder<DiffResult<?>> {
return this;
}
- public DiffBuilder<T> append(
- @NonNull final String fieldName, final char left, final char right, DiffType type) {
-
- if (triviallyEqual) {
- return this;
- }
- if (left != right) {
- diffs.add(new Diff<>(fieldName, left, right, type));
- }
- return this;
- }
-
public DiffBuilder<T> append(
@NonNull final String fieldName, final char[] left, final char[] right, DiffType type) {
@@ -133,18 +91,6 @@ public class DiffBuilder<T> implements Builder<DiffResult<?>> {
return this;
}
- public DiffBuilder<T> append(
- @NonNull final String fieldName, final double left, final double right, DiffType type) {
-
- if (triviallyEqual) {
- return this;
- }
- if (Double.doubleToLongBits(left) != Double.doubleToLongBits(right)) {
- diffs.add(new Diff<>(fieldName, left, right, type));
- }
- return this;
- }
-
public DiffBuilder<T> append(
@NonNull final String fieldName,
final double[] left,
@@ -160,18 +106,6 @@ public class DiffBuilder<T> implements Builder<DiffResult<?>> {
return this;
}
- public DiffBuilder<T> append(
- @NonNull final String fieldName, final float left, final float right, DiffType type) {
-
- if (triviallyEqual) {
- return this;
- }
- if (Float.floatToIntBits(left) != Float.floatToIntBits(right)) {
- diffs.add(new Diff<>(fieldName, left, right, type));
- }
- return this;
- }
-
public DiffBuilder<T> append(
@NonNull final String fieldName,
final float[] left,
@@ -187,18 +121,6 @@ public class DiffBuilder<T> implements Builder<DiffResult<?>> {
return this;
}
- public DiffBuilder<T> append(
- @NonNull final String fieldName, final int left, final int right, DiffType type) {
-
- if (triviallyEqual) {
- return this;
- }
- if (left != right) {
- diffs.add(new Diff<>(fieldName, left, right, type));
- }
- return this;
- }
-
public DiffBuilder<T> append(
@NonNull final String fieldName, final int[] left, final int[] right, DiffType type) {
@@ -211,18 +133,6 @@ public class DiffBuilder<T> implements Builder<DiffResult<?>> {
return this;
}
- public DiffBuilder<T> append(
- @NonNull final String fieldName, final long left, final long right, DiffType type) {
-
- if (triviallyEqual) {
- return this;
- }
- if (left != right) {
- diffs.add(new Diff<>(fieldName, left, right, type));
- }
- return this;
- }
-
public DiffBuilder<T> append(
@NonNull final String fieldName, final long[] left, final long[] right, DiffType type) {
@@ -235,18 +145,6 @@ public class DiffBuilder<T> implements Builder<DiffResult<?>> {
return this;
}
- public DiffBuilder<T> append(
- @NonNull final String fieldName, final short left, final short right, DiffType type) {
-
- if (triviallyEqual) {
- return this;
- }
- if (left != right) {
- diffs.add(new Diff<>(fieldName, left, right, type));
- }
- return this;
- }
-
public DiffBuilder<T> append(
@NonNull final String fieldName,
final short[] left,