[GitHub] [dolphinscheduler] DarkAssassinator commented on a diff in pull request #12130: [Improve][Service] code clean in the Service module

[GitBox <gi...@apache.org>]

DarkAssassinator commented on code in PR #12130:
URL: https://github.com/apache/dolphinscheduler/pull/12130#discussion_r981237610


##########
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java:
##########
@@ -1150,7 +1153,8 @@ private void initComplementDataParam(ProcessDefinition processDefinition,
             complementDate = CronUtils.getSelfScheduleDateList(cmdParam);
         }
 
-        if (complementDate.size() > 0 && Flag.NO == processInstance.getIsSubProcess()) {
+        if (complementDate != null && complementDate.size() > 0 && Flag.NO == processInstance

Review Comment:
   > I made this suggestion because I saw that you mentioned code clean
   
   Sure, u are correct, i will update it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org