You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/17 10:59:04 UTC

[GitHub] [airflow] timqsh opened a new pull request #11613: fix imports sort

timqsh opened a new pull request #11613:
URL: https://github.com/apache/airflow/pull/11613


   Found wrong imports sorting during isort integrations testing :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #11613: fix imports sort

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #11613:
URL: https://github.com/apache/airflow/pull/11613#issuecomment-710821649


   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
   Apache Airflow is a community-driven project and together we are making it better πŸš€.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] timqsh commented on pull request #11613: fix imports sort

Posted by GitBox <gi...@apache.org>.
timqsh commented on pull request #11613:
URL: https://github.com/apache/airflow/pull/11613#issuecomment-722399836


   I looked into changes in the new master. It looks like this fix is no longer needed πŸ™‚


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on pull request #11613: fix imports sort

Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11613:
URL: https://github.com/apache/airflow/pull/11613#issuecomment-721445477


   Can you please rebase your PR on latest Master since we have applied [Black](https://github.com/apache/airflow/commit/4e8f9cc8d02b29c325b8a5a76b4837671bdf5f68) and [PyUpgrade](https://github.com/apache/airflow/commit/8c42cf1b00c90f0d7f11b8a3a455381de8e003c5) on Master.
   
   It will help if your squash your commits into single commit first so that there are less conflicts.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] timqsh commented on pull request #11613: fix imports sort

Posted by GitBox <gi...@apache.org>.
timqsh commented on pull request #11613:
URL: https://github.com/apache/airflow/pull/11613#issuecomment-712125809


   It looks like `skip_glob` flag of isort is confusing. It doesn't work with * and ** like real glob, but rather just treats * like .* in regexp.
   
   I made skips in setup.cfg consistent with pre-commit.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] timqsh closed pull request #11613: fix imports sort

Posted by GitBox <gi...@apache.org>.
timqsh closed pull request #11613:
URL: https://github.com/apache/airflow/pull/11613


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] timqsh commented on pull request #11613: fix imports sort

Posted by GitBox <gi...@apache.org>.
timqsh commented on pull request #11613:
URL: https://github.com/apache/airflow/pull/11613#issuecomment-712129664


   rebased on current master


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org