You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/02/20 02:18:45 UTC
[GitHub] [incubator-pinot] codecov-io commented on issue #5083: Add test for
supporting no dictionary on variable width columns in realtime segments
codecov-io commented on issue #5083: Add test for supporting no dictionary on variable width columns in realtime segments
URL: https://github.com/apache/incubator-pinot/pull/5083#issuecomment-588575067
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5083?src=pr&el=h1) Report
> Merging [#5083](https://codecov.io/gh/apache/incubator-pinot/pull/5083?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/4be7490eeef635157fc62d8750a5dde6e5a5db5e?src=pr&el=desc) will **decrease** coverage by `0.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/5083?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5083 +/- ##
============================================
- Coverage 58.5% 58.28% -0.22%
Complexity 12 12
============================================
Files 1208 1209 +1
Lines 64512 64529 +17
Branches 9482 9483 +1
============================================
- Hits 37741 37613 -128
- Misses 24026 24151 +125
- Partials 2745 2765 +20
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5083?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...l/invertedindex/RealtimeLuceneTextIndexReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/5083/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2ludmVydGVkaW5kZXgvUmVhbHRpbWVMdWNlbmVUZXh0SW5kZXhSZWFkZXIuamF2YQ==) | `0% <0%> (-65.58%)` | `0% <0%> (ø)` | |
| [...invertedindex/RealtimeLuceneIndexRefreshState.java](https://codecov.io/gh/apache/incubator-pinot/pull/5083/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2ludmVydGVkaW5kZXgvUmVhbHRpbWVMdWNlbmVJbmRleFJlZnJlc2hTdGF0ZS5qYXZh) | `46.34% <0%> (-51.22%)` | `0% <0%> (ø)` | |
| [...dindex/RealtimeLuceneIndexReaderRefreshThread.java](https://codecov.io/gh/apache/incubator-pinot/pull/5083/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2ludmVydGVkaW5kZXgvUmVhbHRpbWVMdWNlbmVJbmRleFJlYWRlclJlZnJlc2hUaHJlYWQuamF2YQ==) | `28.88% <0%> (-35.56%)` | `0% <0%> (ø)` | |
| [...ealtime/converter/RealtimeSegmentRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/5083/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9jb252ZXJ0ZXIvUmVhbHRpbWVTZWdtZW50UmVjb3JkUmVhZGVyLmphdmE=) | `58.33% <0%> (-33.34%)` | `0% <0%> (ø)` | |
| [.../pinot/common/config/TextIndexConfigValidator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5083/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL1RleHRJbmRleENvbmZpZ1ZhbGlkYXRvci5qYXZh) | `50% <0%> (-12.5%)` | `0% <0%> (ø)` | |
| [.../impl/dictionary/FloatOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5083/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRmxvYXRPbkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `64.63% <0%> (-12.2%)` | `0% <0%> (ø)` | |
| [...time/converter/stats/RealtimeColumnStatistics.java](https://codecov.io/gh/apache/incubator-pinot/pull/5083/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9jb252ZXJ0ZXIvc3RhdHMvUmVhbHRpbWVDb2x1bW5TdGF0aXN0aWNzLmphdmE=) | `47.29% <0%> (-6.76%)` | `0% <0%> (ø)` | |
| [...mpl/dictionary/DoubleOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5083/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRG91YmxlT2ZmSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `44.08% <0%> (-6.46%)` | `0% <0%> (ø)` | |
| [...e/impl/dictionary/LongOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5083/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTG9uZ09uSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `64.63% <0%> (-6.1%)` | `0% <0%> (ø)` | |
| [.../core/indexsegment/mutable/MutableSegmentImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/5083/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pbmRleHNlZ21lbnQvbXV0YWJsZS9NdXRhYmxlU2VnbWVudEltcGwuamF2YQ==) | `79.01% <0%> (-5.45%)` | `0% <0%> (ø)` | |
| ... and [41 more](https://codecov.io/gh/apache/incubator-pinot/pull/5083/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5083?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5083?src=pr&el=footer). Last update [4be7490...e571679](https://codecov.io/gh/apache/incubator-pinot/pull/5083?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org