[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2761: Towards building on JDK11 and running on JDK8

[GitBox <gi...@apache.org>]

matthiasblaesing commented on a change in pull request #2761:
URL: https://github.com/apache/netbeans/pull/2761#discussion_r579858063



##########
File path: java/api.debugger.jpda/nbproject/project.properties
##########
@@ -21,6 +21,7 @@ javac.compilerargs=-Xlint:unchecked
 javac.source=1.8
 javadoc.arch=${basedir}/arch.xml
 javadoc.apichanges=${basedir}/apichanges.xml
+bootclasspath.prepend=${build.dir}/disable-release

Review comment:
       I assume this line is intended to disable setting the release flag as the module links against internal classes?

##########
File path: platform/o.n.core/test/qa-functional/src/org/netbeans/core/validation/ValidateClassFilesTest.java
##########
@@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.core.validation;
+
+import java.io.DataInputStream;
+import java.io.File;
+import java.io.IOException;
+import java.nio.file.FileVisitResult;
+import java.nio.file.FileVisitor;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.attribute.BasicFileAttributes;
+import java.util.Enumeration;
+import java.util.jar.JarEntry;
+import java.util.jar.JarFile;
+import junit.framework.Test;
+import org.netbeans.junit.NbModuleSuite;
+import org.netbeans.junit.NbTestCase;
+
+public class ValidateClassFilesTest extends NbTestCase {
+    public ValidateClassFilesTest(String name) {
+        super(name);
+    }
+
+    public static Test suite() {
+        return NbModuleSuite.createConfiguration(ValidateClassFilesTest.class).
+                clusters(".*").gui(false).honorAutoloadEager(true).suite();
+    }
+
+    public void testCheckClassFiles() throws IOException {

Review comment:
       Am I reading this right, that this fixates the class versions for _all_ modules to 52 (Java 8?)? If so I don't like this. At this point in time, this might be right (and are we really dropping profiler support for Java prior to 8?), but I see a valid path in the future, where we switch to JDK 11 as boot JDK and will want to be able to use JDK 9+ bytecode for example for modern implementations, that only run on newer JDKs. 

##########
File path: enterprise/web.monitor/build.xml
##########
@@ -27,7 +27,7 @@
 
     <target name="compile-server" depends="init,compile">
         <mkdir dir="build/server-classes"/>
-        <javac srcdir="serversrc" destdir="build/server-classes" deprecation="${build.compiler.deprecation}" debug="${build.compiler.debug}" source="${javac.source}" includeantruntime="false">
+        <javac srcdir="serversrc" destdir="build/server-classes" deprecation="${build.compiler.deprecation}" debug="${build.compiler.debug}" source="${javac.source}" release="8" target="1.8" includeantruntime="false">

Review comment:
       This is the http monitor for web container. I know at least one system where the production runtime, where a webcontainer is running and the java version is << 8. We should be aware, that this might lead to issue reports.

##########
File path: profiler/profiler/nbproject/project.properties
##########
@@ -20,6 +20,7 @@ is.autoload=true
 cp.extra=${tools.jar}
 
 javac.source=1.8
+bootclasspath.prepend=${build.dir}/disable-release

Review comment:
       I assume this is to disable setting "release" version as linking against com.sun classes happens. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists