[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #3059: Returns isUnpartitioned=true for VoidTransform on all fields

[GitBox <gi...@apache.org>]

RussellSpitzer commented on a change in pull request #3059:
URL: https://github.com/apache/iceberg/pull/3059#discussion_r716687748



##########
File path: core/src/test/java/org/apache/iceberg/TestPartitionSpecInfo.java
##########
@@ -65,11 +65,22 @@ public void cleanupTables() {
     TestTables.clearTables();
   }
 
+  @Test
+  public void testSpecIsUnpartitionedForVoidTranforms() {

Review comment:
       I think this test is good. Do we also need a test for a V1 table whose partitioning was removed? I know that was the main reason this has come up in the past. I only wonder because this test explicitly tests the condition created by that situation so we are probably covered.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org