You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@openmeetings.apache.org by GitBox <gi...@apache.org> on 2020/05/11 12:58:17 UTC

[GitHub] [openmeetings] solomax commented on pull request #81: OPENMEETINGS-2347 Fix to apply width based on sidebar same as in room.

solomax commented on pull request #81:
URL: https://github.com/apache/openmeetings/pull/81#issuecomment-626685397


   I believe this issue shouldn't be fixed like this :(((
   code duplications are bad
   
   since variable is no more for room only
   it should be
   1. renamed
   2. moved to rule for `body` (NOT copied)
   
   something like this


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org