Re: Review Request 29332: Add docker_mesos_image flag to slave flags.

[Till Toenshoff <to...@me.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29332/#review72498
-----------------------------------------------------------

Ship it!



src/slave/flags.hpp
<https://reviews.apache.org/r/29332/#comment118547>

    Forgive my non native english speaking attempt to improve the wording (in case it was not an improvement :) )
    
    Suggestion:
    
    ```If an image is specified, the docker containerizer assumes the slave is (was?) running in a docker container. When the slave is recovering, for recovering containers , it launches executors from within docker containers.```


- Till Toenshoff


On Jan. 17, 2015, 1:31 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29332/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2015, 1:31 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add docker_mesos_image flag to slave flags.
> 
> 
> Diffs
> -----
> 
>   src/slave/flags.hpp a4498e6 
> 
> Diff: https://reviews.apache.org/r/29332/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>