You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/01/13 17:40:36 UTC
[GitHub] [helix] NealSun96 commented on a change in pull request #1611: Eliminate redundant job context writes
NealSun96 commented on a change in pull request #1611:
URL: https://github.com/apache/helix/pull/1611#discussion_r556709788
##########
File path: helix-core/src/main/java/org/apache/helix/task/JobContext.java
##########
@@ -281,9 +324,9 @@ public String getName() {
* @param t
*/
public void setExecutionStartTime(long t) {
- String tStr = _record.getSimpleField(ContextProperties.EXECUTION_START_TIME.toString());
- if (tStr == null) {
+ if (getExecutionStartTime() == WorkflowContext.NOT_STARTED) {
Review comment:
Is there a behavior change involved here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org