You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/05/30 18:35:01 UTC
[jira] [Commented] (CB-6822) Plugman usage compatible with Windows
platforms
[ https://issues.apache.org/jira/browse/CB-6822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14013914#comment-14013914 ]
ASF GitHub Bot commented on CB-6822:
------------------------------------
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/66
[CB-6822] plugman compatible on Windows platforms
When createmobilespec module is used and the --plugman argument is
present, it will determine if the development platform is windows to add
node as part of the command.
process.argv[0] it will retrieve the node from the current process, and
it will cover the scenario where the nodejs installation it has a custom
path or it's not present in system PATH environmental variable.
If:
/path/to/nodejs/node createmobilespec.js [args]
process.argv[0] it will retrieve: /path/to/nodejs/node
to invoke plugman main.js file.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/martincgg/cordova-mobile-spec CB-6822
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-mobile-spec/pull/66.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #66
----
commit 1b140bca76c826d3eae09b35da2d1d84face3a0c
Author: Martin Gonzalez <ma...@gmail.com>
Date: 2014-05-30T16:26:40Z
[CB-6822] plugman compatible with windows
When createmobilespec module is used and the --plugman argument is
present, it will determine if the development platform is windows to add
node as part of the command.
process.argv[0] it will retrieve the node from the current process, and
it will cover the scenario where the nodejs installation it has a custom
path or it's not present in system PATH environmental variable.
If:
/path/to/nodejs/node createmobilespec.js [args]
process.argv[0] it will retrieve: /path/to/nodejs/node
to invoke plugman main.js file.
----
> Plugman usage compatible with Windows platforms
> -----------------------------------------------
>
> Key: CB-6822
> URL: https://issues.apache.org/jira/browse/CB-6822
> Project: Apache Cordova
> Issue Type: Bug
> Components: mobile-spec
> Affects Versions: 3.5.0
> Environment: Windows 7 & 8
> Reporter: Martin Gonzalez
> Labels: createmobilespec, mobilespec
> Fix For: 3.6.0
>
>
> When the --plugman arguments is used to create the mobilespec project using the createmobilespec nodejs module, it fails the plugins installation under windows.
> Reason:
> At: https://github.com/apache/cordova-mobile-spec/blob/master/createmobilespec/createmobilespec.js#L180
> The plugman main js script is called, but for windows it only means open the js file with an editor, and for Linux based os uses the #!/usr/bin/env node line at the top of the file to invoke nodejs and execute the file.
> For the Windows platform it's required provide the node command.
--
This message was sent by Atlassian JIRA
(v6.2#6252)