You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@wicket.apache.org by Greg Johnson <gr...@saltaire.com.au> on 2017/11/26 08:31:25 UTC

8.0.0-M8 StoreSettings.setAsynchronous(false) appears not to be honoured

Setting 8.0.0-M8 StoreSettings.setAsynchronous(false) does not prevent pageStore from being wrapped with AsynchronousPageStore - am I missing something?

Thanks, regards, Greg Johnson

DefaultPageManagerProvider.java:

        if (dataStore.canBeAsynchronous()) {
            int capacity = storeSettings.getAsynchronousQueueCapacity();
            dataStore = new AsynchronousDataStore(dataStore, capacity);
            pageStore = newPageStore(dataStore);
            if (pageStore.canBeAsynchronous()) {
                pageStore = new AsynchronousPageStore(pageStore, capacity);
            }
        } else {
            pageStore = newPageStore(dataStore);
        }
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org


Re: 8.0.0-M8 StoreSettings.setAsynchronous(false) appears not to be honoured

Posted by Greg Johnson <gr...@saltaire.com.au>.
https://issues.apache.org/jira/browse/WICKET-6501

Many thanks, regards, Greg Johnson

> On 27 Nov 2017, at 05:46, Martin Grigorov <mg...@apache.org> wrote:
> 
> Yes, it is a regression!
> Please file a ticket!
> 
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
> 
> On Sun, Nov 26, 2017 at 10:31 AM, Greg Johnson <greg.johnson@saltaire.com.au
>> wrote:
> 
>> Setting 8.0.0-M8 StoreSettings.setAsynchronous(false) does not prevent
>> pageStore from being wrapped with AsynchronousPageStore - am I missing
>> something?
>> 
>> Thanks, regards, Greg Johnson
>> 
>> DefaultPageManagerProvider.java:
>> 
>>        if (dataStore.canBeAsynchronous()) {
>>            int capacity = storeSettings.getAsynchronousQueueCapacity();
>>            dataStore = new AsynchronousDataStore(dataStore, capacity);
>>            pageStore = newPageStore(dataStore);
>>            if (pageStore.canBeAsynchronous()) {
>>                pageStore = new AsynchronousPageStore(pageStore,
>> capacity);
>>            }
>>        } else {
>>            pageStore = newPageStore(dataStore);
>>        }
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>> For additional commands, e-mail: users-help@wicket.apache.org
>> 
>> 


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org


Re: 8.0.0-M8 StoreSettings.setAsynchronous(false) appears not to be honoured

Posted by Martin Grigorov <mg...@apache.org>.
Yes, it is a regression!
Please file a ticket!

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Sun, Nov 26, 2017 at 10:31 AM, Greg Johnson <greg.johnson@saltaire.com.au
> wrote:

> Setting 8.0.0-M8 StoreSettings.setAsynchronous(false) does not prevent
> pageStore from being wrapped with AsynchronousPageStore - am I missing
> something?
>
> Thanks, regards, Greg Johnson
>
> DefaultPageManagerProvider.java:
>
>         if (dataStore.canBeAsynchronous()) {
>             int capacity = storeSettings.getAsynchronousQueueCapacity();
>             dataStore = new AsynchronousDataStore(dataStore, capacity);
>             pageStore = newPageStore(dataStore);
>             if (pageStore.canBeAsynchronous()) {
>                 pageStore = new AsynchronousPageStore(pageStore,
> capacity);
>             }
>         } else {
>             pageStore = newPageStore(dataStore);
>         }
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>