[GitHub] [beam] chamikaramj commented on a change in pull request #12638: [BEAM-10769] Clarify Avro IO documentation.

[GitBox <gi...@apache.org>]

chamikaramj commented on a change in pull request #12638:
URL: https://github.com/apache/beam/pull/12638#discussion_r485998552



##########
File path: sdks/python/apache_beam/io/avroio.py
##########
@@ -90,7 +78,7 @@ def __init__(
       file_pattern=None,
       min_bundle_size=0,
       validate=True,
-      use_fastavro=_use_fastavro()):
+      use_fastavro=True):

Review comment:
       So, to clarify, does both Avro and fastavro work for Python even though we set fastavro to default ?

##########
File path: sdks/python/apache_beam/io/avroio.py
##########
@@ -511,7 +488,9 @@ def __init__(
         end in a common extension, if given by file_name_suffix. In most cases,
         only this argument is specified and num_shards, shard_name_template, and
         file_name_suffix use default values.
-      schema: The schema to use, as returned by avro.schema.Parse
+      schema: The schema to use (dict).

Review comment:
       Does fastavro support a more structured definition for schemas or does is have to be a dict ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org