You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/06/14 18:48:11 UTC

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #41597: [SPARK-44055][CORE] Remove redundant `override` functions from `CheckpointRDD`

dongjoon-hyun commented on code in PR #41597:
URL: https://github.com/apache/spark/pull/41597#discussion_r1230033660


##########
core/src/main/scala/org/apache/spark/rdd/CheckpointRDD.scala:
##########
@@ -36,12 +36,4 @@ private[spark] abstract class CheckpointRDD[T: ClassTag](sc: SparkContext)
   override def doCheckpoint(): Unit = { }
   override def checkpoint(): Unit = { }
   override def localCheckpoint(): this.type = this
-
-  // Note: There is a bug in MiMa that complains about `AbstractMethodProblem`s in the
-  // base [[org.apache.spark.rdd.RDD]] class if we do not override the following methods.

Review Comment:
   If MiMa doesn't complain, it makes sense.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org