You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Brian Federle <Br...@citrix.com> on 2013/03/11 18:34:15 UTC
[MERGE] Multiple IPs per NIC UI
Hi all,
I would like to merge in the UI support for the multiple IPs per NIC feature -- https://issues.apache.org/jira/browse/CLOUDSTACK-1628
This adds UI support for functionality to A) acquire NIC IPs via the instances NICs tab, and B) Use the secondary NICs for port forwarding, load balancing, and static NAT.
The UI code currently sits in ui-mulitple-nics.
I will also attach screenshots of the UI to the subtask.
Thanks,
Brian
RE: [MERGE] Multiple IPs per NIC UI
Posted by Brian Federle <Br...@citrix.com>.
Thanks for your suggestions Jayapal. Here are my comments:
>> 1. Place Acquire IP in the nic-view-all.jpg page nic 1(default) heading right side end.
The acquire IP button is on the listing page to keep consistency with existing UI flows. That is, to put the actions on the relevant listing page. Also, putting the add action on the NICs tab would mean the user wouldn't be able to see their newly-acquired IP after the job is done, without having to perform an additional click, which might be annoying from an experience perspective.
>> 2. In nic-port-forwarding-select-ip.jpg
place IP drop down column after the VM name. Also please change the column name to VM IP.
Please change Drop down heading from Use IP to Select VM IP.
The reason it is under the name is because of CSS/wrapping issues that would be caused in cases that the VM name is very long. Also, from a design/proportion issue it looked a bit funny when I tried to put it side-by-side. I'll change the name to 'Select VM IP' though.
>> 3. Make changes for PF, Static NAT. Support for LB for backend is not in master.
You are correct here...sorry in my original message I meant PF and NAT, not LB. I did not make any changes to the LB flow.
-Brian
-----Original Message-----
From: Jayapal Reddy Uradi [mailto:jayapalreddy.uradi@citrix.com]
Sent: Monday, March 11, 2013 9:42 PM
To: cloudstack-dev@incubator.apache.org
Cc: Animesh Chaturvedi; Jessica Wang; Pranav Saxena; Sonny Chhen
Subject: RE: [MERGE] Multiple IPs per NIC UI
Hi Brain,
I have the following suggestions on the UI mock pages in the bug.
1. Place Acquire IP in the nic-view-all.jpg page nic 1(default) heading right side end.
2. In nic-port-forwarding-select-ip.jpg
place IP drop down column after the VM name. Also please change the column name to VM IP.
Please change Drop down heading from Use IP to Select VM IP.
3. Make changes for PF, Static NAT. Support for LB for backend is not in master.
Thanks,
Jayapal
> -----Original Message-----
> From: Brian Federle [mailto:Brian.Federle@citrix.com]
> Sent: Monday, March 11, 2013 11:04 PM
> To: cloudstack-dev@incubator.apache.org
> Cc: Animesh Chaturvedi; Jessica Wang; Pranav Saxena; Sonny Chhen
> Subject: [MERGE] Multiple IPs per NIC UI
>
> Hi all,
>
> I would like to merge in the UI support for the multiple IPs per NIC
> feature --
> https://issues.apache.org/jira/browse/CLOUDSTACK-1628
>
> This adds UI support for functionality to A) acquire NIC IPs via the
> instances NICs tab, and B) Use the secondary NICs for port forwarding,
> load balancing, and static NAT.
>
> The UI code currently sits in ui-mulitple-nics.
>
> I will also attach screenshots of the UI to the subtask.
>
> Thanks,
> Brian
RE: [MERGE] Multiple IPs per NIC UI
Posted by Jayapal Reddy Uradi <ja...@citrix.com>.
Hi Brain,
I have the following suggestions on the UI mock pages in the bug.
1. Place Acquire IP in the nic-view-all.jpg page nic 1(default) heading right side end.
2. In nic-port-forwarding-select-ip.jpg
place IP drop down column after the VM name. Also please change the column name to VM IP.
Please change Drop down heading from Use IP to Select VM IP.
3. Make changes for PF, Static NAT. Support for LB for backend is not in master.
Thanks,
Jayapal
> -----Original Message-----
> From: Brian Federle [mailto:Brian.Federle@citrix.com]
> Sent: Monday, March 11, 2013 11:04 PM
> To: cloudstack-dev@incubator.apache.org
> Cc: Animesh Chaturvedi; Jessica Wang; Pranav Saxena; Sonny Chhen
> Subject: [MERGE] Multiple IPs per NIC UI
>
> Hi all,
>
> I would like to merge in the UI support for the multiple IPs per NIC feature --
> https://issues.apache.org/jira/browse/CLOUDSTACK-1628
>
> This adds UI support for functionality to A) acquire NIC IPs via the instances
> NICs tab, and B) Use the secondary NICs for port forwarding, load balancing,
> and static NAT.
>
> The UI code currently sits in ui-mulitple-nics.
>
> I will also attach screenshots of the UI to the subtask.
>
> Thanks,
> Brian
RE: [MERGE] Multiple IPs per NIC UI
Posted by Brian Federle <Br...@citrix.com>.
Hi all,
UI support for multiple IPs per NIC is now in master and ready for QA.
https://issues.apache.org/jira/browse/CLOUDSTACK-1628
Thanks,
Brian
-----Original Message-----
From: Brian Federle [mailto:Brian.Federle@citrix.com]
Sent: Wednesday, March 13, 2013 11:01 AM
To: cloudstack-dev@incubator.apache.org
Subject: RE: [MERGE] Multiple IPs per NIC UI
You're correct...I'll remove the zone column as it is unnecessary here.
-Brian
-----Original Message-----
From: Chiradeep Vittal [mailto:Chiradeep.Vittal@citrix.com]
Sent: Monday, March 11, 2013 6:06 PM
To: cloudstack-dev@incubator.apache.org
Cc: Animesh Chaturvedi; Jessica Wang; Pranav Saxena; Sonny Chhen
Subject: Re: [MERGE] Multiple IPs per NIC UI
Not sure if the images attached to the bug are still accurate.
If they are, it strikes me that the 'zone' column is extremely redundant.
On 3/11/13 10:56 AM, "Chip Childers" <ch...@sungard.com> wrote:
>On Mon, Mar 11, 2013 at 10:34:15AM -0700, Brian Federle wrote:
>> Hi all,
>>
>> I would like to merge in the UI support for the multiple IPs per NIC
>>feature -- https://issues.apache.org/jira/browse/CLOUDSTACK-1628
>>
>> This adds UI support for functionality to A) acquire NIC IPs via the
>>instances NICs tab, and B) Use the secondary NICs for port forwarding,
>>load balancing, and static NAT.
>>
>> The UI code currently sits in ui-mulitple-nics.
>>
>> I will also attach screenshots of the UI to the subtask.
>>
>> Thanks,
>> Brian
>
>+1 from me.
>
>Looks like a clean diff with master (as of a few moments ago).
>
>git diff --stat ui-multiple-nics..master
> ui/css/cloudstack3.css | 50 +---
> ui/scripts/instances.js | 9 -
> ui/scripts/network.js | 622
>++++++++++++++++++++-----------
> ui/scripts/ui-custom/enableStaticNAT.js | 3 +-
> ui/scripts/ui/widgets/detailView.js | 29 +--
> ui/scripts/ui/widgets/listView.js | 58 +---
> ui/scripts/ui/widgets/multiEdit.js | 12 +-
> 7 files changed, 406 insertions(+), 377 deletions(-)
>
RE: [MERGE] Multiple IPs per NIC UI
Posted by Brian Federle <Br...@citrix.com>.
You're correct...I'll remove the zone column as it is unnecessary here.
-Brian
-----Original Message-----
From: Chiradeep Vittal [mailto:Chiradeep.Vittal@citrix.com]
Sent: Monday, March 11, 2013 6:06 PM
To: cloudstack-dev@incubator.apache.org
Cc: Animesh Chaturvedi; Jessica Wang; Pranav Saxena; Sonny Chhen
Subject: Re: [MERGE] Multiple IPs per NIC UI
Not sure if the images attached to the bug are still accurate.
If they are, it strikes me that the 'zone' column is extremely redundant.
On 3/11/13 10:56 AM, "Chip Childers" <ch...@sungard.com> wrote:
>On Mon, Mar 11, 2013 at 10:34:15AM -0700, Brian Federle wrote:
>> Hi all,
>>
>> I would like to merge in the UI support for the multiple IPs per NIC
>>feature -- https://issues.apache.org/jira/browse/CLOUDSTACK-1628
>>
>> This adds UI support for functionality to A) acquire NIC IPs via the
>>instances NICs tab, and B) Use the secondary NICs for port forwarding,
>>load balancing, and static NAT.
>>
>> The UI code currently sits in ui-mulitple-nics.
>>
>> I will also attach screenshots of the UI to the subtask.
>>
>> Thanks,
>> Brian
>
>+1 from me.
>
>Looks like a clean diff with master (as of a few moments ago).
>
>git diff --stat ui-multiple-nics..master
> ui/css/cloudstack3.css | 50 +---
> ui/scripts/instances.js | 9 -
> ui/scripts/network.js | 622
>++++++++++++++++++++-----------
> ui/scripts/ui-custom/enableStaticNAT.js | 3 +-
> ui/scripts/ui/widgets/detailView.js | 29 +--
> ui/scripts/ui/widgets/listView.js | 58 +---
> ui/scripts/ui/widgets/multiEdit.js | 12 +-
> 7 files changed, 406 insertions(+), 377 deletions(-)
>
Re: [MERGE] Multiple IPs per NIC UI
Posted by Chiradeep Vittal <Ch...@citrix.com>.
Not sure if the images attached to the bug are still accurate.
If they are, it strikes me that the 'zone' column is extremely redundant.
On 3/11/13 10:56 AM, "Chip Childers" <ch...@sungard.com> wrote:
>On Mon, Mar 11, 2013 at 10:34:15AM -0700, Brian Federle wrote:
>> Hi all,
>>
>> I would like to merge in the UI support for the multiple IPs per NIC
>>feature -- https://issues.apache.org/jira/browse/CLOUDSTACK-1628
>>
>> This adds UI support for functionality to A) acquire NIC IPs via the
>>instances NICs tab, and B) Use the secondary NICs for port forwarding,
>>load balancing, and static NAT.
>>
>> The UI code currently sits in ui-mulitple-nics.
>>
>> I will also attach screenshots of the UI to the subtask.
>>
>> Thanks,
>> Brian
>
>+1 from me.
>
>Looks like a clean diff with master (as of a few moments ago).
>
>git diff --stat ui-multiple-nics..master
> ui/css/cloudstack3.css | 50 +---
> ui/scripts/instances.js | 9 -
> ui/scripts/network.js | 622
>++++++++++++++++++++-----------
> ui/scripts/ui-custom/enableStaticNAT.js | 3 +-
> ui/scripts/ui/widgets/detailView.js | 29 +--
> ui/scripts/ui/widgets/listView.js | 58 +---
> ui/scripts/ui/widgets/multiEdit.js | 12 +-
> 7 files changed, 406 insertions(+), 377 deletions(-)
>
Re: [MERGE] Multiple IPs per NIC UI
Posted by Chip Childers <ch...@sungard.com>.
On Mon, Mar 11, 2013 at 10:34:15AM -0700, Brian Federle wrote:
> Hi all,
>
> I would like to merge in the UI support for the multiple IPs per NIC feature -- https://issues.apache.org/jira/browse/CLOUDSTACK-1628
>
> This adds UI support for functionality to A) acquire NIC IPs via the instances NICs tab, and B) Use the secondary NICs for port forwarding, load balancing, and static NAT.
>
> The UI code currently sits in ui-mulitple-nics.
>
> I will also attach screenshots of the UI to the subtask.
>
> Thanks,
> Brian
+1 from me.
Looks like a clean diff with master (as of a few moments ago).
git diff --stat ui-multiple-nics..master
ui/css/cloudstack3.css | 50 +---
ui/scripts/instances.js | 9 -
ui/scripts/network.js | 622 ++++++++++++++++++++-----------
ui/scripts/ui-custom/enableStaticNAT.js | 3 +-
ui/scripts/ui/widgets/detailView.js | 29 +--
ui/scripts/ui/widgets/listView.js | 58 +---
ui/scripts/ui/widgets/multiEdit.js | 12 +-
7 files changed, 406 insertions(+), 377 deletions(-)