You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by dhatchayani <gi...@git.apache.org> on 2018/05/07 05:44:00 UTC
[GitHub] carbondata pull request #2277: [CARBONDATA-2448] Adding compacted segments t...
GitHub user dhatchayani opened a pull request:
https://github.com/apache/carbondata/pull/2277
[CARBONDATA-2448] Adding compacted segments to load and alter events
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dhatchayani/carbondata CARBONDATA-2448
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2277.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2277
----
commit 254c5854328ecdc5be501426bdfa245b11ba2e0e
Author: dhatchayani <dh...@...>
Date: 2018-05-07T05:46:02Z
[CARBONDATA-2448] Adding compacted segments to load and alter events
----
---
[GitHub] carbondata issue #2277: [CARBONDATA-2448] Adding compacted segments to load ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2277
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4526/
---
[GitHub] carbondata issue #2277: [CARBONDATA-2448] Adding compacted segments to load ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2277
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4763/
---
[GitHub] carbondata pull request #2277: [CARBONDATA-2448] Adding compacted segments t...
Posted by manishgupta88 <gi...@git.apache.org>.
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2277#discussion_r186371022
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala ---
@@ -756,13 +756,19 @@ case class CarbonLoadDataCommand(
}
try {
carbonLoadModel.setFactTimeStamp(System.currentTimeMillis())
+ val compactedSegments = new util.ArrayList[String]()
// Trigger auto compaction
CarbonDataRDDFactory.handleSegmentMerging(
sparkSession.sqlContext,
carbonLoadModel,
table,
+ compactedSegments,
operationContext)
-
+ carbonLoadModel.setMergedSegmentIds(compactedSegments)
+ val loadTablePreStatusUpdateEvent: LoadTablePreStatusUpdateEvent =
+ new LoadTablePreStatusUpdateEvent(table.getCarbonTableIdentifier,
+ carbonLoadModel)
+ OperationListenerBus.getInstance().fireEvent(loadTablePreStatusUpdateEvent, operationContext)
--- End diff --
Please re verify. I think LoadTablePreStatusUpdateEvent event is not required to be triggered here
---
[GitHub] carbondata issue #2277: [CARBONDATA-2448] Adding compacted segments to load ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2277
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4772/
---
[GitHub] carbondata issue #2277: [CARBONDATA-2448] Adding compacted segments to load ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2277
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4761/
---
[GitHub] carbondata issue #2277: [CARBONDATA-2448] Adding compacted segments to load ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2277
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4758/
---
[GitHub] carbondata issue #2277: [CARBONDATA-2448] Adding compacted segments to load ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2277
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4774/
---
[GitHub] carbondata issue #2277: [CARBONDATA-2448] Adding compacted segments to load ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2277
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5694/
---
[GitHub] carbondata issue #2277: [CARBONDATA-2448] Adding compacted segments to load ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2277
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4536/
---
[GitHub] carbondata issue #2277: [CARBONDATA-2448] Adding compacted segments to load ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2277
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4759/
---
[GitHub] carbondata issue #2277: [CARBONDATA-2448] Adding compacted segments to load ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2277
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5686/
---
[GitHub] carbondata issue #2277: [CARBONDATA-2448] Adding compacted segments to load ...
Posted by manishgupta88 <gi...@git.apache.org>.
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2277
LGTM
---
[GitHub] carbondata pull request #2277: [CARBONDATA-2448] Adding compacted segments t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2277
---
[GitHub] carbondata issue #2277: [CARBONDATA-2448] Adding compacted segments to load ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2277
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5696/
---
[GitHub] carbondata pull request #2277: [CARBONDATA-2448] Adding compacted segments t...
Posted by manishgupta88 <gi...@git.apache.org>.
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2277#discussion_r186369217
--- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/events/AlterTableEvents.scala ---
@@ -166,7 +166,8 @@ case class AlterTableCompactionPreEvent(sparkSession: SparkSession,
case class AlterTableCompactionPostEvent(sparkSession: SparkSession,
carbonTable: CarbonTable,
carbonMergerMapping: CarbonMergerMapping,
- mergedLoadName: String) extends Event with AlterTableCompactionEventInfo
+ mergedLoadName: String,
+ compactedLoads: java.util.List[String]) extends Event with AlterTableCompactionEventInfo
--- End diff --
if compactedLoads list is added then you can remove mergedLoadName
---